-
Notifications
You must be signed in to change notification settings - Fork 66
Migrate from sbt to bazel #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
44ef690
to
78af2a6
Compare
Cc @KatKlo |
I can start reviewing it this week, but I have almost no experience with Bazel so I will have more questions than useful comments. |
I don't have profound Bazel experience so I can't say anything about the changes. Looks like the docs already mention how to build with |
No problem, I'll do my best to answer them!
That's because bazel-super-formatter I used supports prettier (for the website) and java formatting, but doesn't support scalafmt. I managed to disable java formatting for now, but I'll have to think how to handle scalafmt. |
You can use coursier to download the scalafmt binary in the repo, and then commit it to the repo:
|
No need to, I'll plug scalafmt into the existing formatting pipeline, but it's going to take some work. It's already exposed in |
@lefou all formatting changes should be gone now |
@agluszak Thanks. I have no further comments. LGTM. |
codegen/src/main/kotlin/org/jetbrains/bsp/generators/CodegenFile.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Andrzej Głuszak <[email protected]> Co-authored-by: Scala Steward <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mikołaj Komar <[email protected]> Co-authored-by: juliapodrazka <[email protected]> Co-authored-by: Julia Podrażka <[email protected]> Co-authored-by: Sheng Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my mostly surface-level review, LGTM! I can't evaluate the deeper logic without serious digging. Questions are only for clarification
- name: Fail if we detect changed files | ||
if: steps.verify-changed-files.outputs.files_changed == 'true' | ||
run: | | ||
echo "Detected changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" | ||
echo "Make sure to run 'sbt generate' before pushing." | ||
echo "Make sure to run 'bazel run //:generate' before pushing." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we be able to avoid checking in generated files in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they can be automatically generated, they should, unless there are good reasons not to (e.g. the tooling needs some remote resources temporarily unavailable or unstable).
Closes #613
I also rewrote the Scala codegen in Kotlin, so from now on all generators will use the same IR.