Make DNS configuration optional #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pizzamig I originally implemented this against tag 0.4.4. Maybe we can tag a new release for potnet (mocking.rs seems broken at the moment, I had no nightly around for fixing it - maybe we can change it to something that won't require nightly?) |
|
Added @hny-gd as a potential reviewer, as the end of the year is coming. |
|
Hi. I've updated a few dependencies and everything is fine. You can just rebase and push-f and it everything should be green again! |
If DNS IP is set, DNS name must also be set. In case DNS IP is set in pot.default.conf and it is not matching the network, treat it like unset. This should avoid breakage/annoyance with new setups while it should be backwards compatible, so it won't break existing setups.
grembo
force-pushed
the
dns-ip-optional
branch
from
c794511
to
7b89bae
Compare
pizzamig
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DNS IP is set, DNS name must also be set.
In case DNS IP is set in pot.default.conf and it is not matching the network, treat it like unset.
This should avoid breakage/annoyance with new setups while it should be backwards compatible, so it won't break existing setups.
Addresses bsdpot/pot#264