-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Hardcoded default POT_DNS_IP
causes error when changing POT_NETWORK
#264
Comments
@zilti This error messages comes from bsdpot/potnet:
The actual configuration is in /usr/local/etc/pot/pot.default.conf The default is reflected in the commented out line in pot.conf: https://github.com/bsdpot/pot/blob/master/etc/pot/pot.conf.sample#L52 And can be changed there to fit the network:
So I think everything behaves like expected, doesn't it? |
My expectation would be that there'd be no default for that variable at all, because if I understand the docs correctly, that approach (using a DNS pot) is deprecated anyway. |
@zilti As you can see above, I opened a pull request to potnet that should make DNS IP optional without breaking backwards compatibility. |
Describe the bug
There seems to be a hardcoded default
POT_DNS_IP
which is10.192.0.2
. This breaks when the custom network range does not cover it.To Reproduce
Steps to reproduce the behavior:
POT_NETWORK
to172.16.0.0/12
andPOT_NETMASK
to255.240.0.0
pot init
[ERROR] DNS IP (10.192.0.2) outside the network range (172.16.0.0/12)
Expected behavior
There is no default value for
POT_DNS_IP
and thus nothing breaks.System configuration - if possible
/usr/local/etc/pot/pot.conf
The text was updated successfully, but these errors were encountered: