Bump PayPal Messages to v1.0.0 alpha.1 #1286
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| binary "https://assets.braintreegateway.com/mobile/ios/carthage-frameworks/cardinal-mobile/CardinalMobile.json" == 2.2.5-9 | ||
| binary "https://assets.braintreegateway.com/mobile/ios/carthage-frameworks/pp-risk-magnes/PPRiskMagnes.json" == 5.5.0-static-Xcode15-MinOSVersion100 | ||
| binary "https://github.com/paypal/paypalcheckout-ios/raw/main/Carthage/PayPalCheckout.json" == 1.3.0 | ||
| binary "https://github.com/paypal/paypal-messages-ios/raw/alpha/Carthage/PayPalMessages.json" == 1.0.0-alpha.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import Foundation | ||
| import PayPalMessages | ||
|
|
||
| /// Message location within an application | ||
| /// - Note: This module is in beta. It's public API may change or be removed in future releases. | ||
| public enum BTPayPalMessagingPageType { | ||
|
|
||
| /// Home view | ||
| case home | ||
|
|
||
| /// Individual product details view | ||
| case productDetails | ||
|
|
||
| /// Shopping cart view | ||
| case cart | ||
|
|
||
| /// Popover shopping cart view that covers part of the view | ||
| case miniCart | ||
|
|
||
| /// Checkout view | ||
| case checkout | ||
|
|
||
| /// Search results | ||
| case searchResults | ||
|
|
||
| var pageTypeRawValue: PayPalMessagePageType { | ||
|
There was a problem hiding this comment. It would be nice if we could just expose specific classes from the PayPalMessages library to our merchants. (Don't think Swift allows it) There was a problem hiding this comment. Also, TBH - at this stage (no pilot merchants), I would prefer having merchants directly integrate with the PayPalMessages library versus have our SDK be a tight wrapper around it's public API. Or even having a "module" in our SDK that merely exposes the PayPalMessages library. The decision to wrap it was mostly from product pressure on the Messaging side. Very much an aside/not relevant to this PR - but wanted to give you context. |
||
| switch self { | ||
| case .home: | ||
| return .home | ||
| case .productDetails: | ||
| return .productDetails | ||
| case .cart: | ||
| return .cart | ||
| case .miniCart: | ||
| return .miniCart | ||
| case .checkout: | ||
| return .checkout | ||
| case .searchResults: | ||
| return .searchResults | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import XCTest | ||
| import PayPalMessages | ||
| @testable import BraintreePayPalMessaging | ||
|
|
||
| final class BTPayPalMessagingPageType_Tests: XCTestCase { | ||
|
|
||
| func testPageType_withHome_returnsPageTypeHome() { | ||
| XCTAssertEqual(BTPayPalMessagingPageType.home.pageTypeRawValue, .home) | ||
| } | ||
|
|
||
| func testPageType_withCategory_returnsPageTypeProductDetails() { | ||
| XCTAssertEqual(BTPayPalMessagingPageType.productDetails.pageTypeRawValue, .productDetails) | ||
| } | ||
|
|
||
| func testPageType_withProduct_returnsPageTypeCart() { | ||
| XCTAssertEqual(BTPayPalMessagingPageType.cart.pageTypeRawValue, .cart) | ||
| } | ||
|
|
||
| func testPageType_withCart_returnsPageTypeMiniCart() { | ||
| XCTAssertEqual(BTPayPalMessagingPageType.miniCart.pageTypeRawValue, .miniCart) | ||
| } | ||
|
|
||
| func testPageType_withPayment_returnsPageTypeCheckout() { | ||
| XCTAssertEqual(BTPayPalMessagingPageType.checkout.pageTypeRawValue, .checkout) | ||
| } | ||
|
|
||
| func testPageType_withSearchResults_returnsPageTypeSearchResults() { | ||
| XCTAssertEqual(BTPayPalMessagingPageType.searchResults.pageTypeRawValue, .searchResults) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this accidentally got added under the
6.11.0section at some point but hasn't actually been released. Lets remove it from there and move it underunreleasedand update the names there:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here: f22a9b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets also delete it from the
6.11.0section since it wasn't actually released thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: ae5a8a4