Bump PayPal Messages to v1.0.0 alpha.1 #1286
Conversation
…ageTextAlignmen to PayPalMessageTextAlign
| @@ -3,6 +3,9 @@ | |||
| ## unreleased | |||
| * BraintreePayPalNativeCheckout | |||
| * Bump PayPalCheckout to version 1.3.0 with code signing & a privacy manifest file. | |||
| * BraintreePayPalMessaging (BETA) | |||
There was a problem hiding this comment.
It looks like this accidentally got added under the 6.11.0 section at some point but hasn't actually been released. Lets remove it from there and move it under unreleased and update the names there:
* BraintreePayPalMessaging (BETA)
* Add `BTPayPalMessagingRequest`, `BTPayPalMessagingColor`, `BTPayPalMessagingLogoType`, `BTPayPalMessagingOfferType`, `BTPayPalMessagingPlacement`, `BTPayPalMessagingTextAlignment`, and `BTPayPalMessagingDelegate`
* Add `BTPayPalMessagingView` to display PayPal messages to promote offers such as Pay Later and PayPal Credit to customers.
* To get started create a `BTPayPalMessagingView` and call `start(_:)` with a `BTPayPalMessagingRequest`
There was a problem hiding this comment.
Lets also delete it from the 6.11.0 section since it wasn't actually released there
| /// Search results | ||
| case searchResults | ||
|
|
||
| var pageType: PayPalMessagePageType { |
There was a problem hiding this comment.
update to align with the rest of the module:
| var pageType: PayPalMessagePageType { | |
| var pageTypeRawValue: PayPalMessagePageType { |
| /// Search results | ||
| case searchResults | ||
|
|
||
| var pageTypeRawValue: PayPalMessagePageType { |
There was a problem hiding this comment.
It would be nice if we could just expose specific classes from the PayPalMessages library to our merchants.
(Don't think Swift allows it)
There was a problem hiding this comment.
Also, TBH - at this stage (no pilot merchants), I would prefer having merchants directly integrate with the PayPalMessages library versus have our SDK be a tight wrapper around it's public API.
Or even having a "module" in our SDK that merely exposes the PayPalMessages library. The decision to wrap it was mostly from product pressure on the Messaging side.
Very much an aside/not relevant to this PR - but wanted to give you context.
| @@ -3,6 +3,9 @@ | |||
| ## unreleased | |||
| * BraintreePayPalNativeCheckout | |||
| * Bump PayPalCheckout to version 1.3.0 with code signing & a privacy manifest file. | |||
| * BraintreePayPalMessaging (BETA) | |||
There was a problem hiding this comment.
Lets also delete it from the 6.11.0 section since it wasn't actually released there
Summary of changes
1.0.0-alpha.1Braintree.podspec,Cartfile, and SPM dependency to1.0.0 alpha.1BTPayPalMessagingPlacementtoBTPayPalMessagingPageTypeBTPayPalMessagingPageType. pageTypeBTPayPalMessagingLogoTypeenum case.simpleto:.noneBTPayPalMessagingTextAlignment.textAlignmentRawValueChecklist
Authors