Add --git-describe and --git-rev CLI args#817
Merged
bunnie merged 1 commit intobetrusted-io:mainfrom Feb 12, 2026
Merged
Conversation
Enable reproducible builds without git state by accepting version info as CLI arguments: - --git-describe: version string for signing (e.g., v0.10.0-19-g0d934e1) - --git-rev: commit hash for swap nonce (last 16 hex chars used) Renames xtask --gitrev to --git-describe for clarity.
bunnie
approved these changes
Feb 12, 2026
Member
|
This will be handy for out of tree builds too - if i want to specify a git rev for those. The |
sbellem
added a commit
to sbellem/xous-core
that referenced
this pull request
Feb 13, 2026
Pass semver from --git-describe to swap image signing code path. PR betrusted-io#817 added --git-describe and --git-rev support but the swap image code path in xous-create-image was not updated to use the semver for signing. Changes: - swap_writer.rs: Add semver parameter to encrypt_to() - xous-create-image.rs: Parse --git-describe and pass to encrypt_to() - xous-app-uf2.rs: Same changes for consistency - builder.rs: Pass --git-describe to xous-create-image Fixes betrusted-io#818
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable reproducible builds without git state by accepting version info as CLI arguments:
--git-describe: version string for signing (e.g., v0.10.0-19-g0d934e1)--git-rev: commit hash for swap nonce (last 16 hex chars used)Renames xtask --gitrev to --git-describe for clarity.
Motivation
Build systems like Guix and Nix operate in sandboxed environments without access to
.gitdirectories. Previously, we had to patch the code inline in Guix and Nix package definitions to inject version information at build time. These CLI arguments allow passing version info directly, eliminating the need for source patching.Affected tools
xtask--git-describe,--git-revxous-sign-image--git-describexous-create-image--git-revxous-app-uf2--git-revBreaking change
The xtask
--gitrevargument is renamed to--git-describeto better reflect its purpose (it acceptsgit describeoutput, not a commit hash).Usage
Testing