Fix swap image signing with --git-describe#819
Merged
bunnie merged 1 commit intobetrusted-io:mainfrom Feb 13, 2026
Merged
Conversation
Pass semver from --git-describe to swap image signing code path. PR betrusted-io#817 added --git-describe and --git-rev support but the swap image code path in xous-create-image was not updated to use the semver for signing. Changes: - swap_writer.rs: Add semver parameter to encrypt_to() - xous-create-image.rs: Parse --git-describe and pass to encrypt_to() - xous-app-uf2.rs: Same changes for consistency - builder.rs: Pass --git-describe to xous-create-image Fixes betrusted-io#818
Member
|
Rust 1.93.1 just dropped. Xobs just cut a new release and I'll run CI when that hits. if it's all clean we're good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass semver from
--git-describeto swap image signing code path.PR #817 added
--git-describeand--git-revsupport but the swap image code path inxous-create-imagewas not updated to use the semver for signing.Changes
semverparameter toencrypt_to()--git-describeand pass toencrypt_to()--git-describetoxous-create-imageTest plan
--git-describeand--git-revargumentsFixes #818