[DRAFT] Elixir Optional parameters

README.md

@@ -12,7 +12,7 @@ Code is generated by running the `generate.exs` script. It requires Elixir 1.8.4
 ### Elixir
 
 ```bash
-export SPEC_PATH=../../aws/aws-sdk-go/models/apis
+export SPEC_PATH=../aws-sdk-go-v2/codegen/sdk-codegen/aws-models
 export TEMPLATE_PATH=priv
 export ELIXIR_OUTPUT_PATH=../aws-elixir/lib/aws/generated
 mix run generate.exs elixir $SPEC_PATH $TEMPLATE_PATH $ELIXIR_OUTPUT_PATH
@@ -21,7 +21,7 @@ mix run generate.exs elixir $SPEC_PATH $TEMPLATE_PATH $ELIXIR_OUTPUT_PATH
 ### Erlang
 
 ```bash
-export SPEC_PATH=../../aws/aws-sdk-go/models/apis
+export SPEC_PATH=../aws-sdk-go-v2/codegen/sdk-codegen/aws-models
 export TEMPLATE_PATH=priv
 export ERLANG_OUTPUT_PATH=../aws-erlang/src
 mix run generate.exs erlang $SPEC_PATH $TEMPLATE_PATH $ERLANG_OUTPUT_PATH
@@ -75,5 +75,5 @@ Alternatively you can install XCode's Command Line Developer Tools package:
 
     $ xcode-select --install
 
-[aws-sdk-go]: https://github.com/aws/aws-sdk-go
+[aws-sdk-go]: https://github.com/aws/aws-sdk-go-v2
 [brew]: https://brew.sh/

lib/aws_codegen.ex

@@ -1,4 +1,5 @@
 defmodule AWS.CodeGen do
+  alias AWS.CodeGen.RestService.Parameter
   alias AWS.CodeGen.Spec
 
   @moduledoc """
@@ -132,6 +133,24 @@ defmodule AWS.CodeGen do
     format_string!(context.language, rendered)
   end
 
+  @param_quoted_elixir EEx.compile_string(
+    ~s|* `:<%= parameter.code_name %>` (`t:<%= parameter.type %>`<%= if parameter.required do %> required<% end %>) <%= parameter.docs %>|
+  )
+  def render_parameter(:elixir, %Parameter{} = parameter) do
+    Code.eval_quoted(@param_quoted_elixir, parameter: parameter)
+    |> then(&elem(&1, 0))
+    |> Excribe.format(width: 80, hanging: 4, pretty: true)
+  end
+
+  @body_param_quoted EEx.compile_string(
+    ~s|* `"<%= parameter.location_name %>" => t:<%= parameter.type %>`<%= if parameter.required do %> (required)<% end %> <%= parameter.docs %>|
+  )
+  def render_body_parameter(%Parameter{} = parameter) do
+    Code.eval_quoted(@body_param_quoted, parameter: parameter)
+    |> then(&elem(&1, 0))
+    |> Excribe.format(width: 80, hanging: 4, pretty: true)
+  end
+
   defp format_string!(:elixir, rendered) do
     [Code.format_string!(rendered), ?\n]
   end

lib/aws_codegen/docstring.ex

@@ -10,18 +10,33 @@ defmodule AWS.CodeGen.Docstring do
   heredoc in generated Elixir or Erlang code.
   """
   def format(:elixir, text) do
-    text
-    |> html_to_markdown()
-    |> split_first_sentence_in_one_line()
-    |> split_paragraphs()
-    |> Enum.map(&justify_line(&1, @max_elixir_line_length))
-    |> Enum.join("\n")
-    |> fix_broken_markdown_links()
-    |> fix_elixir_lookalike_format_strings()
-    |> fix_html_spaces()
-    |> fix_long_break_lines()
-    |> transform_subtitles()
-    |> String.trim_trailing()
+    docstring =
+      text
+      |> html_to_markdown()
+      |> fix_broken_markdown_links()
+      |> fix_elixir_lookalike_format_strings()
+      |> fix_html_spaces()
+      |> fix_long_break_lines()
+      |> transform_subtitles()
+      |> String.trim_trailing()
+
+    # Split off the beginning of the docs.
+    [docstring_header, _docstring_rest] =
+      case String.split(docstring, "\n", parts: 3, trim: true) do
+        [a, b, rest] ->
+          [a <> "\n" <> b, rest]
+
+        [a, b] ->
+          [a, b]
+
+        [a] ->
+          [a, ""]
+
+        [] ->
+          ["", ""]
+      end
+
+    docstring_header |> Excribe.format(width: 80, hanging: 2)
   end
 
   def format(:erlang, nil), do: ""
@@ -149,7 +164,7 @@ defmodule AWS.CodeGen.Docstring do
   defp update_nodes({tag, _, children}) when tag in ~w(i em), do: "*#{Floki.text(children)}*"
 
   defp update_nodes({tag, _, children}) when tag in ~w(p fullname note important),
-    do: Floki.text(children) <> @two_break_lines
+    do: (Floki.text(children) |> String.replace("\n", " ")) <> @two_break_lines
 
   defp update_nodes({"a", attrs, children}) do
     case Enum.find(attrs, fn {attr, _} -> attr == "href" end) do
@@ -367,4 +382,22 @@ defmodule AWS.CodeGen.Docstring do
 
     List.flatten(lines ++ [current])
   end
+
+  def docs_url(shapes, operation) do
+    service_name =
+      shapes
+      |> Map.keys()
+      |> List.first()
+      |> then(fn name ->
+        name
+        |> String.split("#")
+        |> hd()
+        |> String.split(".")
+        |> List.last()
+      end)
+
+    op_name = operation |> String.split("#") |> List.last()
+
+    "https://docs.aws.amazon.com/search/doc-search.html?searchPath=documentation&searchQuery=#{service_name}%20#{op_name}&this_doc_guide=API%2520Reference"
+  end
 end