Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Elixir Optional parameters #113

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
75cdac4
Fix link to aws-sdk-go-v2.
Doerge May 30, 2024
fcf9e75
Fix SPEC_PATH in README.
Doerge May 30, 2024
58a5ed2
Move all optional action parameters into Keyword lists, and add
Doerge May 31, 2024
4a9292f
Add the first part of the parameter documentation. E.g. the inner par…
Doerge May 31, 2024
27f1093
Add text wrapping of parameter docs with Excribe.
Doerge May 31, 2024
ee5d7d1
Move params docs near the top of the action docstring.
Doerge Jun 1, 2024
d1515f5
Add link to docs (search).
Doerge Jun 1, 2024
545f5f8
Sort parameters into required and optional in the REST Action
Doerge Jul 16, 2024
dc18ee4
Dirty fix for types named `identifier`. See latest quicksight.
Doerge Jul 16, 2024
3acf04b
Document the `input` params for PostServices.
Doerge Jul 17, 2024
bc51b1a
Fix Rest.
Doerge Jul 17, 2024
ef78fd8
Handle parameters that are sent as HTTP bodies better:
Doerge Jul 19, 2024
45409d6
Remove junk.
Doerge Jul 19, 2024
5490817
Document and and add guards for optional bodies.
Doerge Jul 19, 2024
e732f63
Improve types, guards, specs for both params and body.
Doerge Jul 19, 2024
9e4bb8a
Refactor to use render_def.
Doerge Jul 19, 2024
5836fea
Fix optional body.
Doerge Aug 3, 2024
eeb672d
Add "required" to docstring param docs, and cleanup whitespaces.
Doerge Aug 4, 2024
13925f6
Improve whitespace rendering.
Doerge Aug 4, 2024
6c77d69
Fix body-parameters location name.
Doerge Aug 4, 2024
b79af58
Remove repeated query param usage.
Doerge Aug 4, 2024
7a8317d
Formatting of body param required.
Doerge Aug 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove repeated query param usage.
Doerge committed Aug 4, 2024
commit b79af589ff534c2dba3ffcfd9c56218ed9b925d8
7 changes: 0 additions & 7 deletions priv/rest.ex.eex
Original file line number Diff line number Diff line change
@@ -160,13 +160,6 @@ else %>
<%= inspect((for param <- action.response_header_parameters, do: {param.location_name, param.name}), pretty: true) %>
)<% end %>

<%= if length(action.response_header_parameters) > 0 do %>
options = Keyword.put(
options,
:response_header_parameters,
<%= inspect((for param <- action.response_header_parameters, do: {param.location_name, param.name}), pretty: true) %>
)<% end %>

<%= if action.send_body_as_binary? do %>
options = Keyword.put(
options,