-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let get function take range annotation #769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 81.08% 81.13% +0.04%
==========================================
Files 249 249
Lines 18765 18824 +59
==========================================
+ Hits 15216 15272 +56
- Misses 3549 3552 +3
Continue to review full report at Codecov.
|
3 tasks
3 tasks
This was referenced May 25, 2022
hunterhector
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #694 and #744.
Description of changes
Change the
get
function so that it accepts range annotation, use co-iterator for annotation like, and fix order for non-annotation like subtypes. A helper function that finds the length of entry lists,get_length(self, type_name: str)
, is also included.Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
Tests are added in data_store_test.py.