Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create efficient range annotation iteration #806

Closed
hunterhector opened this issue May 25, 2022 · 0 comments · Fixed by #849
Closed

Create efficient range annotation iteration #806

hunterhector opened this issue May 25, 2022 · 0 comments · Fixed by #849

Comments

@hunterhector
Copy link
Member

Is your feature request related to a problem? Please describe.
The implementation of get with range_annotation is currently inefficient. This is because we actually iterate all annotations, and filter later. A better implementation could be that we search the first and last item, and only iterate in this range, this is similar to the old data pack implementation.

Describe the solution you'd like
As described above.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

  • This is part of the data efficiency project
  • This PR should be made to the master branch.
  • After the data tuple class is finished, we may switch to a new branch for integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant