Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Collections/split] implement split.by support for :char #1876

Merged
merged 3 commits into from
Feb 7, 2025
Merged

[Collections/split] implement split.by support for :char #1876

merged 3 commits into from
Feb 7, 2025

Conversation

RickBarretto
Copy link
Collaborator

@RickBarretto RickBarretto commented Feb 5, 2025 •
edited
Loading

At A Glance

image
image

Fixes #1874

Type of change

  • Code cleanup
  • Unit tests (added or updated unit-tests)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (implementation update, or general performance enhancements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (documentation-related additions)

@github-actions github-actions bot added library Issues related to the standard library unit-test Unit tests → Collections labels Feb 5, 2025
drkameleon
drkameleon approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@drkameleon drkameleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Very nicely done, as usual! 😉

@drkameleon
Copy link
Collaborator

Ready to merge! 🚀

@drkameleon drkameleon merged commit a285640 into arturo-lang:master Feb 7, 2025
13 checks passed
This was referenced Feb 7, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drkameleon drkameleon drkameleon approved these changes

Assignees
No one assigned
Labels
→ Collections library Issues related to the standard library unit-test Unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Collections/split] split.by should work with chars
2 participants
@RickBarretto @drkameleon