-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Nim 2.2.2 #1878
Merged
Merged
Upgrade to Nim 2.2.2 #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready to merge! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd-party
Issues related to 3rd-party libraries and code
critical
Critical, top-priority issues
documentation
Improvements or additions to documentation
helpers
Issues related to Helper modules
Nim
Issues related with Nim (bugs, upgrades, etc)
rosetta code
Issues and PRs related to Rosetta Code snippets
unit-test
Unit tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently, after a seemingly benign PR merge (and the subsequent CI failure lol), I realized there is a new Nim version: https://forum.nim-lang.org/t/12675
The result? LOTS of unit-tests suddenly breaking and from the initial looks of it, all having to do with floating-numbers.
But... apparently not everything is bad news. Actually, it's quite good: nim-lang/Nim@dd0cc38
Now, that means that we'll have to update the expect unit-test results. Which is fine.
But we'll have to make sure that all CI actions pull the "correct" (= 2.2.2) Nim version first. If not, we'd either have to forcefully pass the - previously default -
-d:nimLegacySprintf
option, or have errors.I'd say it's worth some wait, if any.
Fixes: #1261
Fixes: #1879
Type of change