Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Nim 2.2.2 #1878

Merged
merged 33 commits into from
Feb 8, 2025
Merged

Upgrade to Nim 2.2.2 #1878

merged 33 commits into from
Feb 8, 2025

Conversation

drkameleon
Copy link
Collaborator

@drkameleon drkameleon commented Feb 7, 2025

Description

Apparently, after a seemingly benign PR merge (and the subsequent CI failure lol), I realized there is a new Nim version: https://forum.nim-lang.org/t/12675

The result? LOTS of unit-tests suddenly breaking and from the initial looks of it, all having to do with floating-numbers.

But... apparently not everything is bad news. Actually, it's quite good: nim-lang/Nim@dd0cc38

Now, that means that we'll have to update the expect unit-test results. Which is fine.
But we'll have to make sure that all CI actions pull the "correct" (= 2.2.2) Nim version first. If not, we'd either have to forcefully pass the - previously default - -d:nimLegacySprintf option, or have errors.

I'd say it's worth some wait, if any.

Fixes: #1261
Fixes: #1879

Type of change

  • Code cleanup
  • Unit tests (added or updated unit-tests)
  • Bug fix (non-breaking change which fixes an issue)

@drkameleon drkameleon added 3rd-party Issues related to 3rd-party libraries and code critical Critical, top-priority issues ci CI-related issues Nim Issues related with Nim (bugs, upgrades, etc) labels Feb 7, 2025
@github-actions github-actions bot removed 3rd-party Issues related to 3rd-party libraries and code ci CI-related issues labels Feb 7, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation 3rd-party Issues related to 3rd-party libraries and code unit-test Unit tests helpers Issues related to Helper modules rosetta code Issues and PRs related to Rosetta Code snippets labels Feb 8, 2025
@drkameleon
Copy link
Collaborator Author

Ready to merge! 🚀

@drkameleon drkameleon merged commit e57e8df into master Feb 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd-party Issues related to 3rd-party libraries and code critical Critical, top-priority issues documentation Improvements or additions to documentation helpers Issues related to Helper modules Nim Issues related with Nim (bugs, upgrades, etc) rosetta code Issues and PRs related to Rosetta Code snippets unit-test Unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation broken after Nim upgrade [Helpers/bignums] fix warning with newInt, newFloat, newRat
1 participant