kyay10/saga-as-resource #3794
Open
kyay10/saga-as-resource #3794
+23
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kover Report
|
serras
reviewed
Nov 30, 2025
| dependencies { | ||
| api(projects.arrowCore) | ||
| implementation(libs.coroutines.core) | ||
| api(projects.arrowFxCoroutines) |
Member
There was a problem hiding this comment.
My only concern with this PR is that we start depending on fx-coroutines in the resilience package. @nomisRev do we have any rules in place about this? I remember we wanted to keep these concerns somehow separate.
Collaborator
Author
There was a problem hiding this comment.
Mu justification for this was that resilience is part of Arrow Fx, and the core of Arrow Fx seems to be fx-coroutines.
kyay10
force-pushed
the
kyay10/saga-as-resource
branch
from
b1fd85a to
6106954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error suppression logic now matches
resourceScope. Even thoughSagaBuilderis@PublishedApi, it was never used in anyinlinefunction, so it's technicallyprivate. For simplicity, I just deprecated it, but theoretically it could be removed