Use guaranteeCase in CircuitBreaker instead of addSuppressed #3796
+17
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kover Report
|
serras
reviewed
Nov 30, 2025
Member
|
@kyay10 sorry for all the back and forth. I thought splitting |
serras
force-pushed
the
kyay10/circuitBreaker-addSuppressed
branch
from
01cf07e to
123d79e
Compare
Member
|
@kyay10 I've rebased the branch on the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort to unify
addSuppressedusages, this delegates toguaranteeCase; as a nice bonus, the code is cleaner!