Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Release Changes #2050

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Upcoming Release Changes #2050

merged 1 commit into from
Feb 13, 2025

Conversation

theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Feb 13, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Patch Changes

  • #2049
    7c95998
    Thanks @ardatan! - Redirect with correct status codes

  • #2051
    252f68b
    Thanks @ardatan! - Fix crash on null header values during inspect

  • #2009
    5b5ae5f
    Thanks @ardatan! - When fetch('file:///...') is used to read
    files;

    • 404 is returned if the file is missing
    • 403 is returned if the file is not accessible

Summary by CodeRabbit

  • New Features

    • Updated to version 0.7.9.
    • Improved HTTP redirection behavior to return the appropriate status codes.
    • Enhanced local file access handling to return clear error responses (e.g., not found or forbidden).
  • Bug Fixes

    • Resolved stability issues by fixing crash scenarios related to unexpected header values.

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 234502a to 2e56425 Compare February 13, 2025 11:59
Copy link

coderabbitai bot commented Feb 13, 2025

Walkthrough

This pull request removes two changeset files that documented patch updates for the @whatwg-node/node-fetch package. The updates focus on ensuring correct HTTP status codes are returned during redirect handling and when accessing local files via the file:/// protocol (returning 404 or 403 as appropriate). The package’s version has been bumped from 0.7.8 to 0.7.9, and the changelog has been updated to reflect these modifications.

Changes

File(s) Summary
.changeset/few-papayas-fry.md
.changeset/tough-moles-arrive.md
Removed changeset files documenting the patch updates for handling HTTP redirects with proper status codes and managing file access errors (404/403).
packages/node-fetch/CHANGELOG.md
packages/node-fetch/package.json
Updated package metadata for version 0.7.9 with changelog entries that detail improvements in redirect handling and local file error management.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client
    participant NodeFetch as @whatwg-node/node-fetch
    Client->>NodeFetch: Send HTTP request
    NodeFetch->>NodeFetch: Check if response requires redirection
    NodeFetch-->>Client: Return response with proper HTTP redirect status code (e.g., 301/302)
Loading
sequenceDiagram
    participant Client as Client
    participant NodeFetch as @whatwg-node/node-fetch
    Client->>NodeFetch: Request resource via file:/// URL
    NodeFetch->>NodeFetch: Verify file existence and permission
    alt File not found
        NodeFetch-->>Client: Return 404 error
    else Access forbidden
        NodeFetch-->>Client: Return 403 error
    else File found and accessible
        NodeFetch-->>Client: Return file content
    end
Loading

Possibly Related PRs

Poem

Hoppity hops across the code,
Patches erased to lighten the load.
Redirects now twirl with proper grace,
File errors show their proper face.
Version 0.7.9 leaps ahead with glee—
A bouncy update from a rabbit (🐰) like me!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65bba01 and 51c5693.

📒 Files selected for processing (4)
  • .changeset/few-papayas-fry.md (0 hunks)
  • .changeset/tough-moles-arrive.md (0 hunks)
  • packages/node-fetch/CHANGELOG.md (1 hunks)
  • packages/node-fetch/package.json (1 hunks)
💤 Files with no reviewable changes (2)
  • .changeset/tough-moles-arrive.md
  • .changeset/few-papayas-fry.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/node-fetch/package.json
  • packages/node-fetch/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (18)
  • GitHub Check: lint
  • GitHub Check: unit / node 23
  • GitHub Check: unit / deno
  • GitHub Check: unit / node 22
  • GitHub Check: unit / bun
  • GitHub Check: release-candidate / snapshot
  • GitHub Check: unit / node 20
  • GitHub Check: server (undici)
  • GitHub Check: unit / node 18
  • GitHub Check: server (ponyfill)
  • GitHub Check: type check
  • GitHub Check: node-fetch (consumeBody)
  • GitHub Check: e2e / azure-function
  • GitHub Check: server (native)
  • GitHub Check: e2e / aws-lambda
  • GitHub Check: esm
  • GitHub Check: node-fetch (noConsumeBody)
  • GitHub Check: Analyze (javascript-typescript)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 2e56425 to 65bba01 Compare February 13, 2025 12:01
Copy link
Contributor

github-actions bot commented Feb 13, 2025

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.243249 min=13      med=141     max=184     p(90)=163     p(95)=166    
     data_received..................: 21 MB  683 kB/s
     data_sent......................: 13 MB  442 kB/s
     http_req_blocked...............: avg=2.48µs     min=611ns   med=1.35µs  max=6.25ms  p(90)=2.05µs  p(95)=2.31µs 
     http_req_connecting............: avg=333ns      min=0s      med=0s      max=1.5ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.32ms    min=2.6ms   med=21.62ms max=1.17s   p(90)=28.26ms p(95)=30ms   
       { expected_response:true }...: avg=22.32ms    min=2.6ms   med=21.62ms max=1.17s   p(90)=28.26ms p(95)=30ms   
     http_req_failed................: 0.00%  ✓ 0           ✗ 133949
     http_req_receiving.............: avg=33.5µs     min=9.28µs  med=24.43µs max=16.03ms p(90)=39.07µs p(95)=45.78µs
     http_req_sending...............: avg=11.11µs    min=3.56µs  med=6.66µs  max=7.16ms  p(90)=10.22µs p(95)=14.1µs 
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.28ms    min=2.51ms  med=21.59ms max=1.17s   p(90)=28.22ms p(95)=29.95ms
     http_reqs......................: 133949 4464.422364/s
     iteration_duration.............: avg=44.75ms    min=10.62ms med=43.16ms max=1.2s    p(90)=49ms    p(95)=54.38ms
     iterations.....................: 66956  2231.594591/s
     vus............................: 94     min=94        max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Feb 13, 2025

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=141.2003 min=12      med=142     max=172     p(90)=158     p(95)=162    
     data_received..................: 20 MB  661 kB/s
     data_sent......................: 13 MB  423 kB/s
     http_req_blocked...............: avg=2.05µs   min=701ns   med=1.35µs  max=3.71ms  p(90)=2.07µs  p(95)=2.37µs 
     http_req_connecting............: avg=287ns    min=0s      med=0s      max=3.45ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=23.09ms  min=3.44ms  med=22.46ms max=1.23s   p(90)=28.76ms p(95)=30.41ms
       { expected_response:true }...: avg=23.09ms  min=3.44ms  med=22.46ms max=1.23s   p(90)=28.76ms p(95)=30.41ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 129530
     http_req_receiving.............: avg=34.63µs  min=9.79µs  med=24.8µs  max=16.94ms p(90)=39.06µs p(95)=45.5µs 
     http_req_sending...............: avg=10.9µs   min=3.35µs  med=6.32µs  max=10.87ms p(90)=10.13µs p(95)=14.09µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=23.04ms  min=3.41ms  med=22.43ms max=1.23s   p(90)=28.71ms p(95)=30.35ms
     http_reqs......................: 129530 4317.310673/s
     iteration_duration.............: avg=46.29ms  min=10.34ms med=44.63ms max=1.26s   p(90)=49.89ms p(95)=56.33ms
     iterations.....................: 64748  2158.088717/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Feb 13, 2025

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/node-fetch 0.7.9-rc-20250213124156-51c5693dacc9ed4ea5a262237ed71d3535b7db93 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Feb 13, 2025

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 298390    ✗ 0     
     data_received..................: 29 MB   980 kB/s
     data_sent......................: 12 MB   398 kB/s
     http_req_blocked...............: avg=1.4µs    min=901ns    med=1.2µs    max=177.49µs p(90)=1.87µs   p(95)=2.03µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=126.7µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=139.17µs min=94.78µs  med=134.77µs max=7.04ms   p(90)=157.31µs p(95)=164.5µs 
       { expected_response:true }...: avg=139.17µs min=94.78µs  med=134.77µs max=7.04ms   p(90)=157.31µs p(95)=164.5µs 
     http_req_failed................: 0.00%   ✓ 0         ✗ 149195
     http_req_receiving.............: avg=24.6µs   min=12.15µs  med=22.98µs  max=3.15ms   p(90)=30.33µs  p(95)=33.17µs 
     http_req_sending...............: avg=6.22µs   min=3.94µs   med=5.34µs   max=309.56µs p(90)=8.09µs   p(95)=8.77µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=108.34µs min=67.63µs  med=103.6µs  max=5.68ms   p(90)=123.02µs p(95)=128.96µs
     http_reqs......................: 149195  4973.0012/s
     iteration_duration.............: avg=196.64µs min=139.82µs med=191.32µs max=7.38ms   p(90)=217.37µs p(95)=226.75µs
     iterations.....................: 149195  4973.0012/s
     vus............................: 1       min=1       max=1   
     vus_max........................: 1       min=1       max=1   

Copy link
Contributor

github-actions bot commented Feb 13, 2025

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 196846      ✗ 0    
     data_received..................: 20 MB   659 kB/s
     data_sent......................: 7.9 MB  263 kB/s
     http_req_blocked...............: avg=1.37µs   min=871ns    med=1.15µs   max=288.11µs p(90)=1.88µs   p(95)=2.08µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=119.19µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=242.23µs min=186.08µs med=229.54µs max=42.84ms  p(90)=257.45µs p(95)=267.9µs 
       { expected_response:true }...: avg=242.23µs min=186.08µs med=229.54µs max=42.84ms  p(90)=257.45µs p(95)=267.9µs 
     http_req_failed................: 0.00%   ✓ 0           ✗ 98423
     http_req_receiving.............: avg=25.16µs  min=13.59µs  med=23.5µs   max=2.91ms   p(90)=30.53µs  p(95)=33.33µs 
     http_req_sending...............: avg=6.23µs   min=4.04µs   med=5.35µs   max=273.06µs p(90)=8.16µs   p(95)=8.85µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=210.82µs min=161.56µs med=197.94µs max=42.76ms  p(90)=222.99µs p(95)=232.39µs
     http_reqs......................: 98423   3280.649784/s
     iteration_duration.............: avg=300.34µs min=229.88µs med=286.97µs max=43.01ms  p(90)=318.28µs p(95)=330.69µs
     iterations.....................: 98423   3280.649784/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

Copy link
Contributor

github-actions bot commented Feb 13, 2025

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 207054      ✗ 0     
     data_received..................: 21 MB   694 kB/s
     data_sent......................: 8.3 MB  276 kB/s
     http_req_blocked...............: avg=1.43µs   min=911ns    med=1.2µs    max=942.7µs  p(90)=1.93µs   p(95)=2.12µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=114.68µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=226.58µs min=173.24µs med=214.63µs max=7.41ms   p(90)=245.27µs p(95)=259.11µs
       { expected_response:true }...: avg=226.58µs min=173.24µs med=214.63µs max=7.41ms   p(90)=245.27µs p(95)=259.11µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 103527
     http_req_receiving.............: avg=25.56µs  min=14.01µs  med=23.62µs  max=5.81ms   p(90)=31µs     p(95)=34µs    
     http_req_sending...............: avg=6.37µs   min=4.01µs   med=5.51µs   max=290.2µs  p(90)=8.27µs   p(95)=9.08µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=194.64µs min=148.14µs med=182.92µs max=7.32ms   p(90)=209.95µs p(95)=222.44µs
     http_reqs......................: 103527  3450.757867/s
     iteration_duration.............: avg=285.27µs min=218.98µs med=272.29µs max=9.1ms    p(90)=306.81µs p(95)=324.23µs
     iterations.....................: 103527  3450.757867/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@theguild-bot theguild-bot force-pushed the changeset-release/master branch 4 times, most recently from 5d49a5c to b133db4 Compare February 13, 2025 12:27
@theguild-bot theguild-bot force-pushed the changeset-release/master branch from b133db4 to 51c5693 Compare February 13, 2025 12:40
@ardatan ardatan merged commit 0f6399a into master Feb 13, 2025
25 checks passed
This was referenced Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants