Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Release Changes #2081

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Upcoming Release Changes #2081

merged 1 commit into from
Feb 20, 2025

Conversation

theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Feb 20, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Patch Changes

@whatwg-node/[email protected]

Patch Changes

  • #2079
    090b4b0
    Thanks @ardatan! - Fix the bug when set-cookies given is ignored
    in HeadersInit;

    import { Headers } from '@whatwg-node/fetch'
    
    const headers = new Headers([
      ['set-cookie', 'a=b'],
      ['set-cookie', 'c=d']
    ])
    expect(headers.getSetCookie()).toEqual(['a=b', 'c=d']) // Previously it was empty

@whatwg-node/[email protected]

Patch Changes

@whatwg-node/[email protected]

Patch Changes

@benchmarks/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

Summary by CodeRabbit

  • Bug Fixes

    • Resolved an issue with cookie header handling to ensure that multiple cookie values are correctly retrieved for a smoother experience.
  • Chores

    • Updated numerous package versions and dependencies across the system, enhancing overall stability and performance.

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 201bfa5 to 4d96eed Compare February 20, 2025 11:44
Copy link

coderabbitai bot commented Feb 20, 2025

Walkthrough

This pull request removes several changelog files and updates version numbers and dependency versions for multiple packages. The changes include dependency bumps for packages such as @whatwg-node/fetch, @whatwg-node/node-fetch, @whatwg-node/server, and related plugins across benchmarks, end-to-end tests, and core packages. A bug fix addressing the handling of multiple set-cookie headers in the HeadersInit interface is also documented. No changes were made to public API declarations.

Changes

File(s) Change Summary
.changeset/@whatwg-node_*dependencies.md (fetch, server, server-plugin-cookies, curvy-insects-cheer) Deleted changelog entries documenting dependency updates and a set-cookie bug fix.
benchmarks/server/{CHANGELOG.md,package.json} Version update from 0.0.42 to 0.0.43; updated @whatwg-node/server from 0.9.67 to 0.9.68.
e2e/aws-lambda/{CHANGELOG.md,package.json} Bumped version from 0.0.37 to 0.0.38; updated @whatwg-node/fetch from 0.10.3 to 0.10.4.
e2e/shared-server/{CHANGELOG.md,package.json} Updated version from 0.0.130 to 0.0.131; upgraded @whatwg-node/fetch (0.10.3 → 0.10.4) and @whatwg-node/server (0.9.67 → 0.9.68).
e2e/vercel/{CHANGELOG.md,package.json} Version bump from 0.0.130 to 0.0.131; dependency @e2e/shared-server updated from 0.0.130 to 0.0.131.
packages/fetch/{CHANGELOG.md,package.json} Version update from 0.10.3 to 0.10.4; updated @whatwg-node/node-fetch from ^0.7.9 to ^0.7.10; fixed handling of multiple set-cookie headers.
packages/node-fetch/{CHANGELOG.md,package.json} Version bump from 0.7.9 to 0.7.10; includes bug fix related to set-cookie header handling.
packages/server-plugin-cookies/{CHANGELOG.md,package.json} Updated version from 1.0.3 to 1.0.4; dependency on @whatwg-node/server updated from ^0.9.67 to ^0.9.68; updated @whatwg-node/cookie-store to 0.2.2 and removed outdated peer dependency.
packages/server/{CHANGELOG.md,package.json} Version updated from 0.9.67 to 0.9.68; updated @whatwg-node/fetch from ^0.10.3 to ^0.10.4 with corresponding changelog entries.

Possibly related PRs

Suggested reviewers

  • louy

Poem

I'm a rabbit on a joyful spree,
Hopping through code with glee and tea.
Dependencies updated with a skip and a leap,
Bugs fixed in cookies, no promises to keep.
Crunching code like carrots so sweet—
A merry hop in every commit!
🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b217e30 and 0b4738c.

📒 Files selected for processing (20)
  • .changeset/@whatwg-node_fetch-2082-dependencies.md (0 hunks)
  • .changeset/@whatwg-node_server-2082-dependencies.md (0 hunks)
  • .changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md (0 hunks)
  • .changeset/curvy-insects-cheer.md (0 hunks)
  • benchmarks/server/CHANGELOG.md (1 hunks)
  • benchmarks/server/package.json (2 hunks)
  • e2e/aws-lambda/CHANGELOG.md (1 hunks)
  • e2e/aws-lambda/package.json (1 hunks)
  • e2e/shared-server/CHANGELOG.md (1 hunks)
  • e2e/shared-server/package.json (1 hunks)
  • e2e/vercel/CHANGELOG.md (1 hunks)
  • e2e/vercel/package.json (2 hunks)
  • packages/fetch/CHANGELOG.md (1 hunks)
  • packages/fetch/package.json (2 hunks)
  • packages/node-fetch/CHANGELOG.md (1 hunks)
  • packages/node-fetch/package.json (1 hunks)
  • packages/server-plugin-cookies/CHANGELOG.md (1 hunks)
  • packages/server-plugin-cookies/package.json (2 hunks)
  • packages/server/CHANGELOG.md (1 hunks)
  • packages/server/package.json (2 hunks)
💤 Files with no reviewable changes (4)
  • .changeset/@whatwg-node_server-2082-dependencies.md
  • .changeset/@whatwg-node_fetch-2082-dependencies.md
  • .changeset/curvy-insects-cheer.md
  • .changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md
✅ Files skipped from review due to trivial changes (12)
  • packages/node-fetch/package.json
  • e2e/shared-server/CHANGELOG.md
  • benchmarks/server/CHANGELOG.md
  • e2e/aws-lambda/package.json
  • e2e/aws-lambda/CHANGELOG.md
  • packages/fetch/package.json
  • e2e/vercel/CHANGELOG.md
  • benchmarks/server/package.json
  • e2e/vercel/package.json
  • packages/server/package.json
  • e2e/shared-server/package.json
  • packages/server-plugin-cookies/package.json
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: unit / node 23
  • GitHub Check: unit / node 22
  • GitHub Check: unit / deno
  • GitHub Check: unit / node 20
  • GitHub Check: server (undici)
  • GitHub Check: unit / bun
  • GitHub Check: server (ponyfill)
  • GitHub Check: unit / node 18
  • GitHub Check: node-fetch (consumeBody)
  • GitHub Check: e2e / azure-function
  • GitHub Check: server (native)
🔇 Additional comments (4)
packages/server-plugin-cookies/CHANGELOG.md (1)

3-22: Changelog Entry for Version 1.0.4:
This new entry documents the dependency updates in the @whatwg-node/server-plugin-cookies package. It clearly specifies:
– The upgrade of @whatwg-node/cookie-store to version ^0.2.2 in dependencies.
– The addition of @whatwg-node/server at version ^0.9.67 to dependencies, while removing the older version (^0.9.44) from peerDependencies.
– The subsequent update of @whatwg-node/server to version 0.9.68 as part of the overall dependency refresh.

Please ensure that these changelog details accurately mirror the changes in the package manifest and that all version numbers and dependency removals/additions are consistent with the repository’s release notes.

packages/fetch/CHANGELOG.md (1)

3-32: Changelog Entry for Version 0.10.4:
This entry highlights two key updates:
– A dependency update for @whatwg-node/node-fetch (from ^0.7.8 to ^0.7.9, later bumped to 0.7.10) in the context of the package’s dependencies.
– A critical bug fix addressing the issue where multiple set-cookie headers in HeadersInit were previously ignored. The included code snippet demonstrates the correct behavior with output showing both cookies.

Verify that the presented example accurately reflects runtime behavior, and ensure that the dependency updates are aligned with those in related packages.

packages/node-fetch/CHANGELOG.md (1)

3-20: Changelog Entry for Version 0.7.10:
The new changelog entry for version 0.7.10 fixes the bug where multiple set-cookie headers were being ignored in HeadersInit. It includes a concise code snippet to illustrate the expected behavior using the updated functionality of Headers.getSetCookie().

Double-check that the dependency reference and commit IDs are correct and that this update is consistently propagated wherever the @whatwg-node/node-fetch package is used.

packages/server/CHANGELOG.md (1)

3-16: Changelog Entry for Version 0.9.68:
This entry records the updates made to the server package’s dependencies:
– The dependency on @whatwg-node/fetch has been updated from ^0.10.0 to ^0.10.3, and then further bumped to 0.10.4 via the referenced commits.
– The commit links and acknowledgments (e.g. [#2082]) confirm the source of these changes.

It is important to confirm that these dependency updates are consistent across all related packages (such as those in the plugins and benchmarks) and that any behavioral changes (e.g. for plugin responses) are well documented.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 4d96eed to 87b1790 Compare February 20, 2025 11:45
Copy link
Contributor

github-actions bot commented Feb 20, 2025

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/fetch 0.10.4-rc-20250220122131-0b4738c105b1e406b88caee1ba287a49d240a366 npm ↗︎ unpkg ↗︎
@whatwg-node/node-fetch 0.7.10-rc-20250220122131-0b4738c105b1e406b88caee1ba287a49d240a366 npm ↗︎ unpkg ↗︎
@whatwg-node/server 0.9.68-rc-20250220122131-0b4738c105b1e406b88caee1ba287a49d240a366 npm ↗︎ unpkg ↗︎
@whatwg-node/server-plugin-cookies 1.0.4-rc-20250220122131-0b4738c105b1e406b88caee1ba287a49d240a366 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Feb 20, 2025

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.092394 min=12     med=141     max=189    p(90)=163     p(95)=166    
     data_received..................: 21 MB  685 kB/s
     data_sent......................: 13 MB  444 kB/s
     http_req_blocked...............: avg=2.13µs     min=661ns  med=1.27µs  max=4.63ms p(90)=2.02µs  p(95)=2.26µs 
     http_req_connecting............: avg=246ns      min=0s     med=0s      max=1.12ms p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.25ms    min=3.17ms med=21.6ms  max=1.18s  p(90)=28.21ms p(95)=29.9ms 
       { expected_response:true }...: avg=22.25ms    min=3.17ms med=21.6ms  max=1.18s  p(90)=28.21ms p(95)=29.9ms 
     http_req_failed................: 0.00%  ✓ 0           ✗ 134379
     http_req_receiving.............: avg=33.62µs    min=9.67µs med=23.85µs max=9.64ms p(90)=38.3µs  p(95)=44.86µs
     http_req_sending...............: avg=10.52µs    min=3.29µs med=6.34µs  max=9.34ms p(90)=9.95µs  p(95)=13.7µs 
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s     p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.21ms    min=3.14ms med=21.56ms max=1.18s  p(90)=28.16ms p(95)=29.84ms
     http_reqs......................: 134379 4478.849479/s
     iteration_duration.............: avg=44.62ms    min=9.77ms med=42.97ms max=1.2s   p(90)=47.79ms p(95)=54.6ms 
     iterations.....................: 67158  2238.374845/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Feb 20, 2025

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=139.888062 min=36      med=137     max=185    p(90)=163     p(95)=168    
     data_received..................: 20 MB  681 kB/s
     data_sent......................: 13 MB  437 kB/s
     http_req_blocked...............: avg=4.31µs     min=661ns   med=1.21µs  max=7.57ms p(90)=2µs     p(95)=2.25µs 
     http_req_connecting............: avg=2.47µs     min=0s      med=0s      max=7.52ms p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.4ms     min=6.23ms  med=21.74ms max=1.12s  p(90)=28.18ms p(95)=30.01ms
       { expected_response:true }...: avg=22.4ms     min=6.23ms  med=21.74ms max=1.12s  p(90)=28.18ms p(95)=30.01ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 133550
     http_req_receiving.............: avg=31.95µs    min=9.33µs  med=22.75µs max=15.5ms p(90)=36.43µs p(95)=42.94µs
     http_req_sending...............: avg=10.38µs    min=3.19µs  med=5.47µs  max=6.45ms p(90)=9.28µs  p(95)=12.75µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s     p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.35ms    min=6.2ms   med=21.7ms  max=1.12s  p(90)=28.14ms p(95)=29.96ms
     http_reqs......................: 133550 4451.246373/s
     iteration_duration.............: avg=44.89ms    min=20.99ms med=43.21ms max=1.15s  p(90)=49.29ms p(95)=54.77ms
     iterations.....................: 66751  2224.823262/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 87b1790 to ee12c9c Compare February 20, 2025 11:48
Copy link
Contributor

github-actions bot commented Feb 20, 2025

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 236230     ✗ 0     
     data_received..................: 24 MB   791 kB/s
     data_sent......................: 9.4 MB  315 kB/s
     http_req_blocked...............: avg=1.35µs   min=882ns    med=1.14µs   max=200.45µs p(90)=1.83µs   p(95)=1.98µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=128.99µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=192.24µs min=141.26µs med=181.94µs max=7.79ms   p(90)=208.16µs p(95)=217.75µs
       { expected_response:true }...: avg=192.24µs min=141.26µs med=181.94µs max=7.79ms   p(90)=208.16µs p(95)=217.75µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 118115
     http_req_receiving.............: avg=24.73µs  min=13.54µs  med=22.97µs  max=2.52ms   p(90)=30.17µs  p(95)=32.93µs 
     http_req_sending...............: avg=6.21µs   min=4.16µs   med=5.3µs    max=251.74µs p(90)=8.07µs   p(95)=8.53µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=161.29µs min=116.59µs med=150.27µs max=7.75ms   p(90)=173.84µs p(95)=182.25µs
     http_reqs......................: 118115  3937.01062/s
     iteration_duration.............: avg=249.61µs min=182µs    med=238.53µs max=7.87ms   p(90)=268.11µs p(95)=280.4µs 
     iterations.....................: 118115  3937.01062/s
     vus............................: 1       min=1        max=1   
     vus_max........................: 1       min=1        max=1   

Copy link
Contributor

github-actions bot commented Feb 20, 2025

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 299476      ✗ 0     
     data_received..................: 30 MB   983 kB/s
     data_sent......................: 12 MB   399 kB/s
     http_req_blocked...............: avg=1.38µs   min=881ns    med=1.17µs   max=270.66µs p(90)=1.87µs   p(95)=2.03µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=128.26µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=138.4µs  min=93.81µs  med=133.98µs max=5.81ms   p(90)=156.11µs p(95)=163.15µs
       { expected_response:true }...: avg=138.4µs  min=93.81µs  med=133.98µs max=5.81ms   p(90)=156.11µs p(95)=163.15µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 149738
     http_req_receiving.............: avg=24.24µs  min=11.96µs  med=22.74µs  max=3.14ms   p(90)=29.99µs  p(95)=32.64µs 
     http_req_sending...............: avg=6.21µs   min=4.01µs   med=5.37µs   max=316.3µs  p(90)=8.03µs   p(95)=8.67µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=107.94µs min=67.29µs  med=103.15µs max=5.73ms   p(90)=122.24µs p(95)=127.96µs
     http_reqs......................: 149738  4991.086915/s
     iteration_duration.............: avg=195.97µs min=139.18µs med=190.85µs max=6.1ms    p(90)=216.29µs p(95)=225.31µs
     iterations.....................: 149738  4991.086915/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Feb 20, 2025

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 215116      ✗ 0     
     data_received..................: 22 MB   721 kB/s
     data_sent......................: 8.6 MB  287 kB/s
     http_req_blocked...............: avg=1.44µs   min=892ns    med=1.22µs   max=187.13µs p(90)=1.94µs   p(95)=2.12µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=120.37µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=215.07µs min=156.38µs med=202.17µs max=60.11ms  p(90)=229.65µs p(95)=240.18µs
       { expected_response:true }...: avg=215.07µs min=156.38µs med=202.17µs max=60.11ms  p(90)=229.65µs p(95)=240.18µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 107558
     http_req_receiving.............: avg=25.75µs  min=13.88µs  med=23.96µs  max=2.53ms   p(90)=31.44µs  p(95)=34.12µs 
     http_req_sending...............: avg=6.53µs   min=4.11µs   med=5.77µs   max=436.96µs p(90)=8.32µs   p(95)=9.18µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=182.78µs min=131.62µs med=170.36µs max=60.03ms  p(90)=193.85µs p(95)=203.42µs
     http_reqs......................: 107558  3585.120801/s
     iteration_duration.............: avg=274.27µs min=198.41µs med=260.03µs max=60.25ms  p(90)=292.25µs p(95)=306.45µs
     iterations.....................: 107558  3585.120801/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from ee12c9c to 0b4738c Compare February 20, 2025 12:20
@ardatan ardatan merged commit e266605 into master Feb 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants