-
Notifications
You must be signed in to change notification settings - Fork 88
[GENFI] Converter improvements #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NicolasGensollen
merged 32 commits into
aramis-lab:dev
from
MatthieuJoulot:update-genfi
May 11, 2023
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
097f8b1
Enhance verbosity
MatthieuJoulot 1c2f673
convert all runs
MatthieuJoulot 35de330
handle parts of dwi to get them converted
MatthieuJoulot 0a7167e
Handling of philips dwi
MatthieuJoulot 5739891
cleanup 1
MatthieuJoulot d3d674c
rename variables for clarity
MatthieuJoulot 9c834b0
add docstrings
MatthieuJoulot bfb59f8
Add some more documentation to compute_philips_parts
MatthieuJoulot 4de1e76
Apply suggestion from review
MatthieuJoulot ee2bb46
apply helper function as suggested
MatthieuJoulot 7a5b5e8
Update clinica/iotools/converters/genfi_to_bids/genfi_to_bids_utils.py
MatthieuJoulot 0d33f59
Merge branch 'dev' into update-genfi
MatthieuJoulot bfc45bd
Apply suggestions from code review
MatthieuJoulot be180a9
update _compute_scan_sequence_number
MatthieuJoulot 2a9f268
Merge remote-tracking branch 'origin/update-genfi' into update-genfi
MatthieuJoulot 13429f3
apply suggestions
MatthieuJoulot 97563b6
modify merge_diffusion_philips
MatthieuJoulot 9eca294
update unit-test
MatthieuJoulot 0705884
Replace pd.NA by np.nan for unit-tests to work
MatthieuJoulot 679ca08
build unit-test for compute_runs
MatthieuJoulot 004f9e6
Add more unit-tests
MatthieuJoulot dd3eb62
Apply suggestions from code review
MatthieuJoulot b3f1d5c
handle PhilipsDWI better
MatthieuJoulot 0b9d6c3
handle PhilipsDWI better
MatthieuJoulot 019cdc0
split function
MatthieuJoulot d80de71
change unit test following the suggestion
MatthieuJoulot 57007d4
apply suggestion from code review
MatthieuJoulot 7b0233f
Apply suggestions from code review
MatthieuJoulot 5a92f1d
correct error from suggestion
MatthieuJoulot a950cea
Add documentation
MatthieuJoulot 8154d31
Apply suggestions from code review
MatthieuJoulot 18abeb8
correct format
MatthieuJoulot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.