Write output-file-map.json atomically #7406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
Does this apply to Windows? That needs to be verified before we can merge this as we shouldn't regress it. |
MaxDesiatov
approved these changes
Mar 19, 2024
ahoppen
force-pushed
the
ahoppen/write-output-file-map-atomically
branch
from
7c927fa
to
64610bc
Compare
|
@swift-ci Please test |
There are two subtle changes in behavior here: - This call will fail if the file system doesn’t support atomic operations. I’m not sure if we need to support file systems that don’t allow atomic operations here. rdar://124727242
ahoppen
force-pushed
the
ahoppen/write-output-file-map-atomically
branch
from
64610bc
to
f9d3e99
Compare
|
@swift-ci Please test |
|
@swift-ci please test Windows platform |
ahoppen
added a commit
that referenced
this pull request
Mar 25, 2024
* **Explanation**: When using sourcekit-lsp with VS Code it often happens that sourcekitd is trying to read the `output-file-map.json` while SwiftPM is writing it non-atomically. This results in a buffer in sourcekitd that is not null-terminated. To fix this issue, generate the output file map atomically. * **Scope**: Generation of `output-file-map.json` * **Risk**: This could fail if the `FileSystem` subclass in SwiftPM does not support atomic write operations. But I think we only really care about the local file system here, which does support atomic operations * **Testing**: Tests continue passing. I will verify that this fixes the sourcekitd crashes when a new toolchain is released with the fix * **Issue**: rdar://124727242 * **Reviewer**: @MaxDesiatov on #7406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two subtle changes in behavior here:
rdar://124727242