[6.0] Write output-file-map.json atomically #7415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two subtle changes in behavior here: - This call will fail if the file system doesn’t support atomic operations. I’m not sure if we need to support file systems that don’t allow atomic operations here. rdar://124727242
ahoppen
added
swift 6.0
bnbarham
approved these changes
Mar 20, 2024
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output-file-map.jsonwhile SwiftPM is writing it non-atomically. This results in a buffer in sourcekitd that is not null-terminated. To fix this issue, generate the output file map atomically.output-file-map.jsonFileSystemsubclass in SwiftPM does not support atomic write operations. But I think we only really care about the local file system here, which does support atomic operations