Skip to content

Fix request body serializing with FORMAT clause #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Conversation

nezed
Copy link
Collaborator

@nezed nezed commented Jun 1, 2019

Fixes #25
Relates to #36

@nezed nezed added the bug label Jun 1, 2019
@nezed nezed requested a review from apla June 1, 2019 19:29
@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #39 into master will increase coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   87.81%   88.47%   +0.66%     
==========================================
  Files           5        5              
  Lines         320      321       +1     
==========================================
+ Hits          281      284       +3     
+ Misses         39       37       -2
Impacted Files Coverage Δ
src/streams.js 98.76% <ø> (ø) ⬆️
src/clickhouse.js 97.5% <100%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba31ad...5df0726. Read the comment docs.

@nezed nezed marked this pull request as ready for review June 1, 2019 19:31
stream.end ();
});

it ("select data with FORMAT clause", function () {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it makes sense to put in a separate test

@apla apla merged commit 263e564 into master Jun 1, 2019
@nezed nezed deleted the fix-format-clause branch June 1, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The last blank is trimed,so how to fix this error
3 participants