Skip to content

Deprecate useless format option #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nezed opened this issue May 26, 2019 · 0 comments
Open

Deprecate useless format option #36

nezed opened this issue May 26, 2019 · 0 comments

Comments

@nezed
Copy link
Collaborator

nezed commented May 26, 2019

The problem:

Clickhouse understands the FORMAT statement which is accepted for both read (SELECT/DESCRIBE/SHOW/etc) and write (INSERT) kinds of queries.

That means format public option is redundant because we'll always have to parse FORMAT value from query.

For now, we have several issues related to it:

Proposed solution:

  • Mark format option as deprecated and remove it from public options later
  • Improve handling of FORMAT statement
  • Get rid of unimplemented inputFormat references (It useless too)

@apla are you agree with this solution?
I can add deprecation warning to master, for current 1+ releases and create 2.0.0 branch with deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants