fix: cluster supports specifing PVC annotations and labels #8804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8804 +/- ##
==========================================
- Coverage 60.34% 60.32% -0.03%
==========================================
Files 381 381
Lines 46215 46221 +6
==========================================
- Hits 27889 27883 -6
- Misses 15654 15664 +10
- Partials 2672 2674 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
size/XL
leon-inf
reviewed
Jan 15, 2025
| @@ -152,7 +152,9 @@ func (r *ClusterComponentStatus) GetObjectMessage(objectKind, objectName string) | |||
| func (r *ClusterComponentVolumeClaimTemplate) toVolumeClaimTemplate() corev1.PersistentVolumeClaimTemplate { | |||
| return corev1.PersistentVolumeClaimTemplate{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: r.Name, | |||
| Labels: r.Labels, | |||
There was a problem hiding this comment.
Refer to this PR and consolidate the transformation of VCTs to PVCs and PVCTs: #8809
leon-inf
reviewed
Jan 15, 2025
github-actions
bot
added
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8805
By applying different annotations to different type of PVC, Ape-local can set different IO quotas for various volumes.