Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cluster supports specifing pvc annotations and labels #8799

Open
wants to merge 7 commits into
base: release-0.9
Choose a base branch
from

Conversation

gnolong
Copy link
Contributor

@gnolong gnolong commented Jan 13, 2025

ref #8804
By applying different annotations to different type of PVC, Ape-local can set different IO quotas for various volumes.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jan 13, 2025
@gnolong gnolong marked this pull request as ready for review January 13, 2025 11:43
@gnolong gnolong requested review from leon-inf, Y-Rookie and a team as code owners January 13, 2025 11:43
@wangyelei
Copy link
Contributor

wangyelei commented Jan 14, 2025

pls also support it in 1.0 branch

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.48%. Comparing base (766a530) to head (2488bcc).
Report is 4 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/component/rsm_convertor.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8799      +/-   ##
===============================================
- Coverage        64.58%   64.48%   -0.11%     
===============================================
  Files              359      359              
  Lines            46317    46373      +56     
===============================================
- Hits             29914    29903      -11     
- Misses           13723    13786      +63     
- Partials          2680     2684       +4     
Flag Coverage Δ
unittests 64.48% <66.66%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf added this to the Release 0.9.3 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] supports specifing different annotations for different type of PVC
5 participants