Skip to content

[SPARK-54400][SQL] Replace HtmlUtils.parseQueryString in ThriftHttpServlet.java with HttpServletRequest.getQueryString #53119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-54400][SQL] Replace HtmlUtils.parseQueryString in ThriftHttpServlet.java with HttpServletRequest.getQueryString #53119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...hive-thriftserver/src/main/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
SessionManager.setUserName(clientUserName);

// find proxy user if any from query param
String doAsQueryParam = getDoAsQueryParam(request.getQueryString());
String doAsQueryParam = getDoAsQueryParam(request);
if (doAsQueryParam != null) {
SessionManager.setProxyUserName(doAsQueryParam);
}
Expand Down Expand Up @@ -546,14 +546,15 @@ private boolean isKerberosAuthMode(String authType) {
return authType.equalsIgnoreCase(HiveAuthFactory.AuthTypes.KERBEROS.toString());
}

private static String getDoAsQueryParam(String queryString) {
private static String getDoAsQueryParam(HttpServletRequest request) {
String queryString = request.getQueryString();
if (LOG.isDebugEnabled()) {
LOG.debug("URL query string:" + queryString);
}
if (queryString == null) {
return null;
}
Map<String, String[]> params = jakarta.servlet.http.HttpUtils.parseQueryString( queryString );
Map<String, String[]> params = request.getParameterMap();
Set<String> keySet = params.keySet();
for (String key: keySet) {
if (key.equalsIgnoreCase("doAs")) {
Expand Down