[SPARK-54400][SQL] Replace HtmlUtils.parseQueryString in ThriftHttpServlet.java with HttpServletRequest.getQueryString
#53119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Nov 18, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending CIs). Thank you so much, @sarutak .
Member
|
Merged to master for Apache Spark 4.2.0. |
Member
Author
|
Thank you @dongjoon-hyun . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to replace
HtmlUtils.parseQueryStringinThriftHttpServlet.javawithHttpServletRequest.getQueryStringWhy are the changes needed?
HttpUtilswas deprecated in Servlet 5.0 and removed in 6.0.https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/httputils
This change is necessary for upgrading Jetty to 12 in #53116
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.