Bugfix/update NPM dependencies #48123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
vincbeck
as code owners
boring-cyborg
bot
added
area:API
|
Note: I started and clicked a bit through the UI. No special plan. But it seems nothing obvious broke. Triggered some DAGs and navigated around. In my naive tests all look good. |
hussein-awala
approved these changes
Mar 23, 2025
shubhamraj-git
approved these changes
Mar 23, 2025
There was a problem hiding this comment.
Fixed some merge conflicts, which happened due to recent editConnection UI PR went in. Overall looks good. Thanks for the changes @jscheffl .
This was referenced Mar 23, 2025
eladkal
approved these changes
Mar 23, 2025
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are close to 3.0 we should upgrade all NPM/ts dependencies to a current state.
After the general upgrade unfortunately some new code was re-generated. Also I needed to ignore some es-lint complaints which are introduced by new version of es-lint. For me they are all classified as false-positives. But still feel partly a bit noob on TS, so if there is a "clean" way to fix it... ideas welcome.