Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AceConfig conversion #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Jakobud
Copy link

@Jakobud Jakobud commented Feb 1, 2023

@anzz1 I had some ideas for new features to add to your awesome Tooltip addon. However as I started to dig into it, I found that added new configuration settings to the Interface Options was very troublesome.

Since all the configuration settings checkboxes, dropdowns, etc were using absolute coordinates in the window, it made it really difficult to add new settings without shifting everything around manually, etc.

Also, the options frame did not have any kinda of scrollframe wrapper on it, so you could not add more settings without building a scrollframe around it so that they could fit in the window.

Anyways, my solution was to convert the entire configuration codebase to use the AceConfigDialog library. This accomplishes a few things:

  1. The configuration code is greatly simplified
  2. Easy to add/remove/relocate various settings
  3. The frame will scroll when you get too many settings in the window
  4. Built-in support for elements like groups, sliders, etc.
  5. Automatic support for multiple configuration profiles that can be duplicated, copied, reset, etc.

So the summarize, the addon should "behave" exactly as before. All the settings do the same thing as before. They simply were converted into a AceConfigDialog system. I added only the bare minimum number of Ace libraries for this. My goal with this PR was to setup the code so that more features could easily be added to your addon.

Some outstanding items:

  1. The addon version needs to be incremented. I'll leave that up to you to determine what the new version would be
  2. I updated and added a few strings in the EnUS locale file. There will need to be a handful of translation updates for these. Should I just use Google Translate for these?

A quick screenshot of the new config. Some features are automatically hidden/visible depending on other setting values (for example Guild Rank Style)

image

Some of the new features I have been looking into adding into TacoTip:

  1. Tooltip scaling
  2. Multiple texture options for the health and power bars
  3. More detailed control over exactly what shows up in the tooltip
  4. Border options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant