Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of size=() like in pytorch #1615

Merged

Conversation

zetyquickly
Copy link
Contributor

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zetyquickly - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ternaus
Copy link
Collaborator

ternaus commented Apr 1, 2024

word TODO, we should probably remove as well, having Deprecated in the code should be enough.

And to pass linting / type checks it is recommended to set up pre-commit hook following https://github.com/albumentations-team/albumentations/blob/main/CONTRIBUTING.md

@zetyquickly
Copy link
Contributor Author

word TODO, we should probably remove as well, having Deprecated in the code should be enough.

And to pass linting / type checks it is recommended to set up pre-commit hook following https://github.com/albumentations-team/albumentations/blob/main/CONTRIBUTING.md

changed to NOTE.

@zetyquickly zetyquickly force-pushed the zetyquickly/issue1587 branch from ce14fe8 to 795df20 Compare April 1, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants