Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech debt] Update interface for RandomRain #1629

Closed
ternaus opened this issue Apr 5, 2024 · 2 comments
Closed

[Tech debt] Update interface for RandomRain #1629

ternaus opened this issue Apr 5, 2024 · 2 comments
Labels
good first issue Good for newcomers Tech debt

Comments

@ternaus
Copy link
Collaborator

ternaus commented Apr 5, 2024 •
edited
Loading

Right now in the transform we have separate parameters for slant_lower and slant_upper

Better would be to have one parameter slant_range = [slant_lower, slant_upper]

=>

We can update transform to use new signature, keep old as working, but mark as deprecated.

PR could be similar to #1704
@ternaus ternaus added good first issue Good for newcomers Tech debt labels Apr 5, 2024
@MarognaLorenzo
Copy link
Contributor

Hi, I would like to work on it

@ternaus
Copy link
Collaborator Author

ternaus commented May 20, 2024

Addressed in #1728

@ternaus ternaus closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ternaus @MarognaLorenzo