Skip to content

Challenge-response for attestation #494

Challenge-response for attestation

Challenge-response for attestation #494

GitHub Actions / clippy succeeded Sep 23, 2024 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 230 in trustchain-http/src/requester.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&String` instead of `&str` involves a new object where a slice will do

warning: writing `&String` instead of `&str` involves a new object where a slice will do
   --> trustchain-http/src/requester.rs:230:11
    |
230 |     ddid: &String,
    |           ^^^^^^^ help: change this to: `&str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 213 in trustchain-http/src/attestation_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&PathBuf` instead of `&Path` involves a new object where a slice will do

warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
   --> trustchain-http/src/attestation_utils.rs:213:44
    |
213 |     fn elementwise_deserialize(self, path: &PathBuf) -> Result<Option<Self>, TrustchainCRError>
    |                                            ^^^^^^^^ help: change this to: `&Path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 199 in trustchain-http/src/attestation_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&PathBuf` instead of `&Path` involves a new object where a slice will do

warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
   --> trustchain-http/src/attestation_utils.rs:199:43
    |
199 |     fn elementwise_serialize(&self, path: &PathBuf) -> Result<(), TrustchainCRError> {
    |                                           ^^^^^^^^ help: change this to: `&Path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `#[warn(clippy::ptr_arg)]` on by default

Check warning on line 170 in trustchain-http/src/attestation_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

direct implementation of `ToString`

warning: direct implementation of `ToString`
   --> trustchain-http/src/attestation_utils.rs:166:1
    |
166 | / impl ToString for Nonce {
167 | |     fn to_string(&self) -> String {
168 | |         self.0.clone()
169 | |     }
170 | | }
    | |_^
    |
    = help: prefer implementing `Display` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
    = note: `#[warn(clippy::to_string_trait_impl)]` on by default