Challenge-response for attestation #494
Triggered via pull request
September 23, 2024 15:38
sgreenbury
Status
Success
Total duration
2m 47s
Artifacts
–
Annotations
9 warnings
|
rustfmt
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
trustchain-http/src/requester.rs#L230
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> trustchain-http/src/requester.rs:230:11
|
230 | ddid: &String,
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do:
trustchain-http/src/attestation_utils.rs#L213
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
--> trustchain-http/src/attestation_utils.rs:213:44
|
213 | fn elementwise_deserialize(self, path: &PathBuf) -> Result<Option<Self>, TrustchainCRError>
| ^^^^^^^^ help: change this to: `&Path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do:
trustchain-http/src/attestation_utils.rs#L199
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
--> trustchain-http/src/attestation_utils.rs:199:43
|
199 | fn elementwise_serialize(&self, path: &PathBuf) -> Result<(), TrustchainCRError> {
| ^^^^^^^^ help: change this to: `&Path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
direct implementation of `ToString`:
trustchain-http/src/attestation_utils.rs#L166
warning: direct implementation of `ToString`
--> trustchain-http/src/attestation_utils.rs:166:1
|
166 | / impl ToString for Nonce {
167 | | fn to_string(&self) -> String {
168 | | self.0.clone()
169 | | }
170 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
clippy_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Docs
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|