Add ansible vars file

[JimMadge]

✅ Checklist

• You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
• You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
• Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

#2092

⤴️ Summary

Adds an ansible vars file, which is constructed in the infrastructure code and uploaded to the desired state share by Pulumi.
Includes changes from #2103 for release v5.0.0

🌂 Related issues

Closes #2075

🔬 Tests

Tested on a fresh deployment.
All vars and templates as expected and system is working.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/infrastructure/common
ip_ranges.py
data_safe_haven/infrastructure/components/composite
__init__.py
nfsv3_blob_container.py					22-29, 39-75
data_safe_haven/infrastructure/components/wrapped
__init__.py
nfsv3_storage_account.py					34-35
data_safe_haven/infrastructure/programs
declarative_sre.py					342, 367
data_safe_haven/infrastructure/programs/sre
data.py					463, 477, 492
desired_state.py					63-84, 98-220, 224
networking.py					486, 1561, 1969-1974
workspaces.py					50
Project Total

This report was generated by python-coverage-comment-action

[jemrobinson]

It might be easier to wait until release 5.0.0 is tagged (next week?) and merged back into develop before looking further into this. What do you think @JimMadge ? We could migrate other variables into this file too and close #2075 in the process.

[JimMadge]

I don't think this would have to wait for the release, as those changes will be merged back into develop anyway.

In the first instance, I'd want to check that this works before moving all variables from cloud init across.
If it does, we could move all of them in this PR though 👍.

[jemrobinson]

I think I'd like to see:

• test that this works on a fresh deployment
• if it does, see how many other variables can be moved across

I agree there's no explicit problem in merging into develop before we tag v5.0.0 but note that this branch contains some changes that are already in release-v5.0.0 and aren't in develop so it would be cleaner if we could:

• merge release-v5.0.0 into latest
• tag release 5.0.0
• merge latest into develop
• THEN merge this PR into develop

[JimMadge]

I think I'd like to see:

* test that this works on a fresh deployment

* if it does, see how many other variables can be moved across

👍

I agree there's no explicit problem in merging into develop before we tag v5.0.0 but note that this branch contains some changes that are already in release-v5.0.0 and aren't in develop so it would be cleaner if we could:

* merge `release-v5.0.0` into `latest`
* tag release 5.0.0
* merge `latest` into `develop`
* THEN merge this PR into `develop`

I can't see that. They are the same changes end up in develop either way and it won't cause any conflicts.

[jemrobinson]

Sorry, I meant cleaner in terms of the logic not whether there will be git conflicts (I agree - there won't be). If we merge release-v5.0.0 first then the logic is:

• this change was made in anticipation of release 5.0.0
• it was merged back into develop when the release was made
• then another PR that makes changes on top of that was added to develop

rather than

• this change was made in anticipation of release 5.0.0
• it was also separately made in another PR meged into develop

[JimMadge]

The vars file is being templated.

[JimMadge]

Templating works

root@shm-daimyo-sre-hojo-vm-workspace-01:~# ls /etc/skel/Desktop/
gitea.desktop  hedgedoc.desktop  input.desktop  output.desktop  shared.desktop
root@shm-daimyo-sre-hojo-vm-workspace-01:~# cat /etc/skel/Desktop/{gitea,hedgedoc}.desktop
[Desktop Entry]
Version=1.0
Type=Link
Name=Gitea
Comment=
Icon=/usr/local/share/icons/gitea.png
URL=http://gitea.hojo.daimyo.develop.turingsafehaven.ac.uk
[Desktop Entry]
Version=1.0
Type=Link
Name=HedgeDoc
Comment=
Icon=/usr/local/share/icons/hedgedoc.png
URL=http://hedgedoc.hojo.daimyo.develop.turingsafehaven.ac.uk

[jemrobinson]

@JimMadge: worth picking up after RSECon?

[jemrobinson]

Overall LGTM. A couple of comments though.