Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy ansible #2192

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Tidy ansible #2192

merged 6 commits into from
Sep 25, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Sep 19, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

#2092
#2115

⤴️ Summary

🌂 Related issues

Closes #2096

🔬 Tests

Tested on a fresh deployment. All Ansible tasks run correctly.

@JimMadge JimMadge changed the base branch from develop to ansible_vars_file September 19, 2024 13:51
Copy link

github-actions bot commented Sep 19, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/infrastructure/programs
  declarative_sre.py
Project Total  

This report was generated by python-coverage-comment-action

Base automatically changed from ansible_vars_file to develop September 20, 2024 09:12
@JimMadge
Copy link
Member Author

Some issues with workspaces deploying and getting to the desired state service before the ansible vars file blob has been created.

Trying to fix that by adding a depends_on.

@JimMadge
Copy link
Member Author

Still seems to be a delay between the pulumi resource being created and the file being available over NFS.
Adding a line to cloud init to wait for the vars file fixed this.

@JimMadge JimMadge marked this pull request as ready for review September 24, 2024 09:47
@JimMadge JimMadge requested a review from a team as a code owner September 24, 2024 09:47
Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit 3f7dce5 into develop Sep 25, 2024
11 checks passed
@JimMadge JimMadge deleted the tidy_ansible branch September 25, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidy Ansible
2 participants