-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ProgressReport-Feb24-Aug24.md #71
Conversation
initial updates
added missing stories: TRESA
Added missing sotries: PM
added priorities and plans sections
formatted some spacing (spaces after titles)
Does this supersede #69? |
Do you need fresh reviews of that PR then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few places where the Markdown could be better formatted. Using semantic line breaks helps readability, creating diffs and reviewing.
There are some rules (or conventions) like blank lines before and after lists which some parsers will handle but others won't. It is best to be strict with those to avoid rendering problems. We could add a Markdown linting workflow or pre-commit hook?
Using links instead of writing URLs should make the document look a lot tidier.
There are places where the English could be better. I think shorter sentences are easier to understand. Some of that may be my preference though. Confusion with i.e. and e.g..
Apply suggestions from review Co-authored-by: Jim Madge <[email protected]>
Thanks for that review @JimMadge ! Will get on with that.
Applied the suggested ones and will review for more.
Same, applied and will review. Would be keen to add that workflow
I've heard conflicting feedback on preferences, happy to go either way. URLs are more evident and could be more accesible, links look nicer.
I tend to write quite long sentences (even in Spanish which lends itself better to it), and need a second or third pass to rewrite those but you are right. |
@jemrobinson thanks for mentioning, I will add to comms yeah. But please do add details via suggestions (might have missed it in the weekly but I saw no more info). You too @harisood In general, please do feel free and encouraged to add/modify things to the report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing spacing
https://prettier.io/docs/en/ Could be a good choice for linting. It does formatting and integrates nicely with pre-commit. @Davsarper do you want to open an issue for that? |
commit suggestions from review Co-authored-by: Arielle-Bennett <[email protected]>
All conversations resolved, @JimMadge your requested changed should be made already but it still shows them as waiting for those to be addressed, do you need to re-review or have I missed some? |
Co-authored-by: Matt Craddock <[email protected]>
Co-authored-by: Matt Craddock <[email protected]>
Co-authored-by: Matt Craddock <[email protected]>
DSH progress report for this month, created a new one as the last one covered a whole year already and it also made it easier to apply format changes and updates.
The idea is to use this file until August.
This report now includes a section for priorities, the idea being that a significant aprt of the Monthly meeting can be asynchronous leaving time together for other discussions.