-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ReproducibleBuilds.md with cygwin details #3973
Open
judovana
wants to merge
20
commits into
adoptium:master
Choose a base branch
from
judovana:comparableReadmeUpdate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
20feacc
Update ReproducibleBuilds.md with cygwin details
judovana c2cbbca
Mentioned that jdk use don path must not be jdk whichis being patched
judovana 12437e5
Mentioned also classpath
judovana 7f9cbf9
Fixing markup lint
judovana 6eb7990
Update tooling/reproducible/ReproducibleBuilds.md
judovana f8d8074
Update tooling/reproducible/ReproducibleBuilds.md
judovana b3b8934
Update tooling/reproducible/ReproducibleBuilds.md
judovana b6efaac
Update tooling/reproducible/ReproducibleBuilds.md
judovana 164dfc7
Update tooling/reproducible/ReproducibleBuilds.md
judovana 8c58dff
Update tooling/reproducible/ReproducibleBuilds.md
judovana 9cbc886
Update tooling/reproducible/ReproducibleBuilds.md
judovana 6cd4bc3
Update tooling/reproducible/ReproducibleBuilds.md
judovana 6c6479c
Update tooling/reproducible/ReproducibleBuilds.md
judovana b5e7e17
Merge branch 'master' into comparableReadmeUpdate
judovana 8f8492b
Merge branch 'adoptium:master' into comparableReadmeUpdate
judovana d1d5614
removed surpassed 777 from ReproducibleBuilds.md
judovana 7e660c9
Update tooling/reproducible/ReproducibleBuilds.md
karianna b57ac2f
Update tooling/reproducible/ReproducibleBuilds.md
karianna 9597d5d
Merge branch 'master' into comparableReadmeUpdate
judovana 1b2f20e
Removed full example f extracting the the properties out of vm
judovana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@judovana I think this is far too complex for "doc"... I am thinking we need a helper script that does all this for a user... called something like "SetupReproEnv.bat" and "SetupComparableEnv.bat", we then make this doc very simple....thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have finished the publishable script yesterday. Will make PR with it today I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would be great, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that that script is nto that simple. Depnending on MSVS, MSVC lcoations, cygwin, architectures and so on...:(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it goes: