Update ReproducibleBuilds.md with cygwin details #3973
Conversation
github-actions
bot
added
the
documentation
|
@judovana linter failures |
|
nice! ty! |
judovana
force-pushed
the
comparableReadmeUpdate
branch
2 times, most recently
from
51b4092
to
b4d4b09
Compare
judovana
force-pushed
the
comparableReadmeUpdate
branch
from
b4d4b09
to
7f9cbf9
Compare
|
goodnow. Thanx again! |
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
|
TYVM! @andrew-m-leonard wdyt? |
| In cygwin, you must handle the trailing `\r` otherwise it will fail later: | ||
|
|
||
| ```bash | ||
| JAVA_VENDOR="$($JDK_DIR/bin/java -XshowSettings 2>&1| grep 'java.vendor = ' | sed 's/.* = //' | sed 's/\r.*//' )" |
There was a problem hiding this comment.
The other URLs ought to be handled if we're doing this
There was a problem hiding this comment.
Thsi was just example. In addition targeted to of removing the \r You have listing of all fo them in th e readem. I would not repeat them all here. I fyou insists, I will copypaste them all.
There was a problem hiding this comment.
I think just remove this, this is assuming someone is using a "script" to get these, when I wrote this I was simply running the command, and copy and pasting from the terminal, hence "\r" does not come into it...
Lets keep this doc simple please
There was a problem hiding this comment.
Sure! As you wish. Removed. I had kept jsut inline "sed \r away as eg: sed 's/\r.*//' is usually enough."
| - Thus, it is recommended to launch this via `cmd -c` or preferably by an executable `.bat` file such as: | ||
|
|
||
| ```bash | ||
| pushd "$MSVSC/BUILD/TOOLS" |
There was a problem hiding this comment.
@judovana I think this is far too complex for "doc"... I am thinking we need a helper script that does all this for a user... called something like "SetupReproEnv.bat" and "SetupComparableEnv.bat", we then make this doc very simple....thoughts?
There was a problem hiding this comment.
I have finished the publishable script yesterday. Will make PR with it today I think
There was a problem hiding this comment.
that would be great, thanks
There was a problem hiding this comment.
Note that that script is nto that simple. Depnending on MSVS, MSVC lcoations, cygwin, architectures and so on...:(
There was a problem hiding this comment.
Here it goes:
- https://github.com/adoptium/temurin-build/pull/3991/files#diff-2784c99fa0623d2a010b722632d7c57648182ac4c7b6138d9a6fcb44e2fe139aR196
- https://github.com/adoptium/temurin-build/pull/3991/files#diff-2784c99fa0623d2a010b722632d7c57648182ac4c7b6138d9a6fcb44e2fe139aR142
- https://github.com/adoptium/temurin-build/pull/3991/files#diff-2784c99fa0623d2a010b722632d7c57648182ac4c7b6138d9a6fcb44e2fe139aR172
Few notes I learned when launched through cygwin. Still not complete, but the parts covered inthis readme are moreover done