Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to release notes is not prominent on the releases page #2128

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Link to release notes is not prominent on the releases page #2128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b09c20
Link to release notes is not prominent on the releases page
xavierfacq Aug 21, 2023
bc8a505
Update src/components/TemurinDownloadTable/index.tsx
xavierfacq Aug 21, 2023
da9456e
Improve css after stylelint report
xavierfacq Aug 21, 2023
bd70630
Move source code link to the header
xavierfacq Aug 21, 2023
3f79078
Improve css
xavierfacq Aug 21, 2023
8c9adf2
Improve css 2/2
xavierfacq Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/components/Layout/layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,15 @@ iframe {
.font-poppins {
font-family: Poppins, sans-serif;
}

.release-notes {
padding: 5px 0 10px 0;
border-top: 4px solid #333;
background-color: #f8f9fa !important;
margin-bottom: 5px;
border-right: 1px solid var(--bs-border-color);

a svg {
margin-right: 5px;
}
}
24 changes: 22 additions & 2 deletions ...omponents/TemurinDownloadTable/__tests__/__snapshots__/TemurinDownloadTable.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@ exports[`TemurinDownloadTable component > renders correctly - no data 1`] = `

exports[`TemurinDownloadTable component > renders correctly - with source 1`] = `
<div>
<p>
<p
class="release-notes"
>
<a
href="/temurin/release-notes?version=mock-release-name"
style="padding-right: 20px;"
>
<svg
fill="currentColor"
Expand All @@ -39,7 +42,24 @@ exports[`TemurinDownloadTable component > renders correctly - with source 1`] =
d="M3 18h12v-2H3v2zM3 6v2h18V6H3zm0 7h18v-2H3v2z"
/>
</svg>

Text
</a>
<a
href="/installation/"
>
<svg
fill="currentColor"
height="1em"
stroke="currentColor"
stroke-width="0"
viewBox="0 0 512 512"
width="1em"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M256 48C141.1 48 48 141.1 48 256s93.1 208 208 208 208-93.1 208-208S370.9 48 256 48zm61 356l-12.2-39.6c13-5.8 24.9-14 35.3-24.4 10.4-10.4 18.6-22.3 24.4-35.3l39.5 12.1c-7.9 19.3-19.7 37-34.9 52.2-15.1 15.3-32.8 27.1-52.1 35zM195 108l12.2 39.6c-13 5.8-24.9 14-35.3 24.4-10.4 10.4-18.6 22.3-24.4 35.3L108 195.2c7.9-19.3 19.7-37 34.9-52.2 15.1-15.3 32.8-27.1 52.1-35zm61 84c35.3 0 64 28.7 64 64s-28.7 64-64 64-64-28.7-64-64 28.7-64 64-64zm113.1-49.1c15.2 15.2 26.9 32.9 34.9 52.1l-39.5 12.2c-5.9-13-14-24.9-24.4-35.3-10.4-10.4-22.3-18.6-35.3-24.4l12.1-39.5c19.3 7.9 37 19.7 52.2 34.9zM142.9 369.1c-15.2-15.1-27-32.8-34.9-52.1l39.5-12.2c5.9 13 14 24.9 24.4 35.3 10.4 10.4 22.3 18.6 35.3 24.4L195.1 404c-19.3-7.9-37-19.7-52.2-34.9z"
/>
</svg>
Text
</a>
</p>
Expand Down
6 changes: 5 additions & 1 deletion src/components/TemurinDownloadTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { MdNotes } from 'react-icons/md';
import { MdVerifiedUser } from 'react-icons/md';
import { capitalize } from '../../util/capitalize';
import { localeDate } from '../../util/localeDate';
import { IoMdHelpBuoy } from 'react-icons/io';

const TemurinDownloadTable = ({results}) => {
const { language } = useI18next();
Expand All @@ -16,7 +17,10 @@ const TemurinDownloadTable = ({results}) => {
return (
<>
{source &&
<p><Link to={`/temurin/release-notes?version=${source.release_name}`}><MdNotes /> <Trans>Release Notes</Trans></Link></p>
<p className='release-notes'>
<Link to={`/temurin/release-notes?version=${source.release_name}`} style={{paddingRight: '20px'}}><MdNotes /><Trans>See Release Notes</Trans></Link>
<Link to="/installation/"><IoMdHelpBuoy /><Trans>Read how to install Eclipse Temurin™</Trans></Link>
xavierfacq marked this conversation as resolved.
Show resolved Hide resolved
</p>
}
<table id="download-table" className="table table-bordered releases-table" style={{borderSpacing: '0 10px', borderCollapse: 'separate'}}>
<tbody className="table-light">
Expand Down