Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to release notes is not prominent on the releases page #2128

Conversation

xavierfacq
Copy link
Member

Description of change

This PR is submitted to fix the point N°1 of the issue #1508
1 - Link to release notes is not prominent on the releases page. The notes should be easily found.

@tellison suggested this good idea: The "release notes" looks a bit lonely on that wide screen too, so maybe we could include a link to the installation pages alongside it too (or something equally relevant).

image

Checklist

  • npm test passes

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 8c9adf2
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64e3b98b3102f20008ca01e6
😎 Deploy Preview https://deploy-preview-2128--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2128 (8c9adf2) into main (f1a6ee8) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2128   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          85       85           
  Lines        6270     6274    +4     
  Branches      535      534    -1     
=======================================
+ Hits         6218     6222    +4     
  Misses         52       52           
Files Changed Coverage Δ
src/components/TemurinDownloadTable/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment on lines 21 to 22
<Link to={`/temurin/release-notes?version=${source.release_name}`} style={{paddingRight: '20px'}}><MdNotes /><Trans>See Release Notes</Trans></Link>
<Link to="/installation/"><IoMdHelpBuoy /><Trans>Read how to install Eclipse Temurin</Trans></Link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work with shorter text, e.g. "Release Notes", "Installation Guide", "Source Code"

The source code link is currently below the binaries table.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test your proposal and let you know

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the source code is already in the page, at the bottom of the table:

image

I can move it into the header like that:

image

@xavierfacq xavierfacq marked this pull request as ready for review August 21, 2023 14:44
@xavierfacq xavierfacq marked this pull request as draft August 21, 2023 14:47
@xavierfacq xavierfacq marked this pull request as ready for review August 21, 2023 19:20
@xavierfacq
Copy link
Member Author

✔️ Ok, everything is fine, I have finaly choose to add the 3 links into the header of the table.

Design is now:

image

@gdams gdams merged commit fb75f63 into adoptium:main Aug 22, 2023
11 checks passed
@xavierfacq xavierfacq deleted the Link_to_release_notes_is_not_prominent_on_the_releases_page branch September 7, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants