style: fix lint complains

adjust · Aug 31, 2022 · d64b62d · d64b62d
1 parent 03e0e18
commit d64b62d
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 11 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -51,7 +51,8 @@
         ],
         "eol-last": "error",
         "@typescript-eslint/ban-types": "warn",
-        "@typescript-eslint/explicit-module-boundary-types": "off"
+        "@typescript-eslint/explicit-module-boundary-types": "off",
+        "@typescript-eslint/no-namespace": "warn"
       }
     },
     {

diff --git a/src/sdk/__tests__/smart-banner/network/api.spec.ts b/src/sdk/__tests__/smart-banner/network/api.spec.ts
@@ -19,7 +19,7 @@ describe('Smart banner API tests', () => {
       button_label: 'Go!'
     }
 
-    let testNetwork: Network = {
+    const testNetwork: Network = {
       endpoint: 'test-endpoint',
       request: jest.fn()
     }

diff --git a/src/sdk/__tests__/smart-banner/network/url-startegy-network.spec.ts b/src/sdk/__tests__/smart-banner/network/url-startegy-network.spec.ts
@@ -102,7 +102,7 @@ describe('NetworkWithUrlStrategy', () => {
       try {
         await network.request('/whatever')
       } catch (err) {
-
+        // nothing to do here
       }
 
       expect(network.endpoint).toEqual(defaultEndpoint)

diff --git a/src/sdk/__tests__/smart-banner/network/url-strategy/blocked-url-bypass.spec.ts b/src/sdk/__tests__/smart-banner/network/url-strategy/blocked-url-bypass.spec.ts
@@ -2,7 +2,7 @@ import { BlockedUrlBypass } from '../../../../smart-banner/network/url-strategy/
 import { BaseUrlsMap } from '../../../../smart-banner/network/url-strategy/url-strategy'
 
 describe('BlockedUrlBypass', () => {
-  let testEndpoints: Record<BlockedUrlBypass.Strategy, BaseUrlsMap> = {
+  const testEndpoints: Record<BlockedUrlBypass.Strategy, BaseUrlsMap> = {
     [BlockedUrlBypass.Default]: {
       endpointName: BlockedUrlBypass.Default,
       app: 'app',

diff --git a/src/sdk/__tests__/smart-banner/network/url-strategy/url-strategy.spec.ts b/src/sdk/__tests__/smart-banner/network/url-strategy/url-strategy.spec.ts
@@ -16,7 +16,7 @@ describe('UrlStrategy', () => {
   }]
 
   const preferredUrlsMock = jest.fn()
-  let testedUrlStrategy = new UrlStrategy(preferredUrlsMock)
+  const testedUrlStrategy = new UrlStrategy(preferredUrlsMock)
   const sendRequestMock = jest.fn()
 
   beforeAll(() => {

diff --git a/src/sdk/smart-banner/network/url-strategy/blocked-url-bypass.ts b/src/sdk/smart-banner/network/url-strategy/blocked-url-bypass.ts
@@ -1,4 +1,4 @@
-import { BaseUrlsMap } from "./url-strategy"
+import { BaseUrlsMap } from './url-strategy'
 
 export namespace BlockedUrlBypass {
   export const Default = 'default'
@@ -7,7 +7,7 @@ export namespace BlockedUrlBypass {
 
   export type Strategy = typeof Default | typeof India | typeof China
 
-  let endpoints: Record<BlockedUrlBypass.Strategy, BaseUrlsMap> = {
+  const endpoints: Record<BlockedUrlBypass.Strategy, BaseUrlsMap> = {
     [BlockedUrlBypass.Default]: {
       endpointName: 'Default',
       app: 'https://app.adjust.com',
@@ -25,7 +25,7 @@ export namespace BlockedUrlBypass {
     }
   }
 
-  let getPreferredUrlsWithOption = (endpoints: Record<BlockedUrlBypass.Strategy, BaseUrlsMap>, option?: BlockedUrlBypass.Strategy) => {
+  const getPreferredUrlsWithOption = (endpoints: Record<BlockedUrlBypass.Strategy, BaseUrlsMap>, option?: BlockedUrlBypass.Strategy) => {
 
     if (option === BlockedUrlBypass.India) {
       return [

diff --git a/src/sdk/smart-banner/network/url-strategy/custom-url.ts b/src/sdk/smart-banner/network/url-strategy/custom-url.ts
@@ -1,5 +1,5 @@
 export namespace CustomUrl {
-  let getPreferredUrlsWithOption = (customUrl: string) => {
+  const getPreferredUrlsWithOption = (customUrl: string) => {
 
     return [{
       endpointName: `Custom (${customUrl})`,

diff --git a/src/sdk/smart-banner/network/url-strategy/data-residency.ts b/src/sdk/smart-banner/network/url-strategy/data-residency.ts
@@ -1,4 +1,4 @@
-import { BaseUrlsMap } from "./url-strategy"
+import { BaseUrlsMap } from './url-strategy'
 
 export namespace DataResidency {
   export const EU = 'EU'
@@ -25,7 +25,7 @@ export namespace DataResidency {
     }
   }
 
-  let getPreferredUrlsWithOption = (endpoints: Record<DataResidency.Region, BaseUrlsMap>, option: DataResidency.Region) => {
+  const getPreferredUrlsWithOption = (endpoints: Record<DataResidency.Region, BaseUrlsMap>, option: DataResidency.Region) => {
     return [endpoints[option]]
   }