Skip to content

Commit

Permalink
fix: circular dependency in network module
Browse files Browse the repository at this point in the history
  • Loading branch information
YaraMatkova committed Aug 31, 2022
1 parent c845370 commit 03e0e18
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/sdk/__tests__/smart-banner/network/api.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Logger from '../../../logger'
import { DeviceOS } from '../../../smart-banner/detect-os'
import { fetchSmartBannerData, Position } from '../../../smart-banner/api'
import { Network } from '../../../smart-banner/network'
import { Network } from '../../../smart-banner/network/network'

jest.mock('../../../logger')

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Network } from '../../../smart-banner/network'
import { Network } from '../../../smart-banner/network/network'
import { NetworkWithUrlStrategy } from '../../../smart-banner/network/url-startegy-network'
import { UrlStrategy } from '../../../smart-banner/network/url-strategy/url-strategy'
import { UrlStrategyFactory } from '../../../smart-banner/network/url-strategy/url-strategy-factory'
Expand Down
2 changes: 1 addition & 1 deletion src/sdk/__tests__/smart-banner/network/xhr-network.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { XhrNetwork } from '../../../smart-banner/network'
import { XhrNetwork } from '../../../smart-banner/network/xhr-network'
import { NoConnectionError } from '../../../smart-banner/network/errors'

jest.mock('../../../logger')
Expand Down
2 changes: 1 addition & 1 deletion src/sdk/smart-banner/api.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Logger from '../logger'
import { DeviceOS } from './detect-os'
import { Network } from './network'
import { Network } from './network/network'

export enum Position {
Top = 'top',
Expand Down
9 changes: 0 additions & 9 deletions src/sdk/smart-banner/network/index.ts

This file was deleted.

2 changes: 1 addition & 1 deletion src/sdk/smart-banner/network/url-startegy-network.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { NetworkDecorator, Network } from './network'
import { NetworkDecorator, Network } from '../network/network'
import { UrlStrategy } from './url-strategy/url-strategy'
import { UrlStrategyFactory, UrlStrategyConfig } from './url-strategy/url-strategy-factory'
import { NetworkError } from './errors'
Expand Down
4 changes: 3 additions & 1 deletion src/sdk/smart-banner/smart-banner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ import { getDeviceOS } from './detect-os'
import { storage } from './local-storage'
import { fetchSmartBannerData, SmartBannerData } from './api'
import { SmartBannerView } from './view/smart-banner-view'
import { Network, NetworkWithUrlStrategy, XhrNetwork } from './network'
import { Network } from './network/network'
import { XhrNetwork } from './network/xhr-network'
import { NetworkWithUrlStrategy } from './network/url-startegy-network'
import { DataResidency } from './network/url-strategy/data-residency'

type LogLevel = 'none' | 'error' | 'warning' | 'info' | 'verbose'
Expand Down

0 comments on commit 03e0e18

Please sign in to comment.