Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-BME688 #462

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add-BME688 #462

merged 1 commit into from
Aug 7, 2023

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Aug 7, 2023

Adds BME688 as an alias of BME680, tested with two on the bus (QTPY-ESP32s2)
image

@tyeth tyeth mentioned this pull request Aug 7, 2023
@tyeth tyeth marked this pull request as ready for review August 7, 2023 15:52
@tyeth
Copy link
Contributor Author

tyeth commented Aug 7, 2023

It's based on the add-bmp388 branch so should merge easy enough, but will happily rebase it if desired - just ping me

@tyeth tyeth requested a review from lorennorman August 7, 2023 15:59
@brentru
Copy link
Member

brentru commented Aug 7, 2023

@tyeth See my comments on the BMP388 branch, we'll work on getting that golden and then rebase this when it's set!

@tyeth tyeth force-pushed the add-BME688 branch 2 times, most recently from b487877 to 8755d88 Compare August 7, 2023 16:52
@tyeth tyeth removed the request for review from lorennorman August 7, 2023 17:24
@tyeth
Copy link
Contributor Author

tyeth commented Aug 7, 2023

@brentru rebased.

@brentru brentru merged commit 7cf3092 into adafruit:main Aug 7, 2023
24 checks passed
@tyeth tyeth deleted the add-BME688 branch August 24, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants