Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BMP388 / BMP3xx #461

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Add BMP388 / BMP3xx #461

merged 6 commits into from
Aug 7, 2023

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Aug 7, 2023 •
edited
Loading

Adds BMP388, tested with two connected to QTPYs2.
image
image

@tyeth tyeth marked this pull request as ready for review August 7, 2023 15:47
@tyeth
Copy link
Contributor Author

tyeth commented Aug 7, 2023

@lorennorman Ready for review, then #462 please :) I think Brents going to be away most of this week, so look out for some component definitions in the next few days (probably Wednesday)

@tyeth tyeth requested a review from lorennorman August 7, 2023 15:59
@tyeth
Copy link
Contributor Author

tyeth commented Aug 7, 2023

@brentru assuming you're away but if not then feel free to grab this and #462 instead of Loren

@brentru brentru self-requested a review August 7, 2023 16:19
@tyeth
Copy link
Contributor Author

tyeth commented Aug 7, 2023

@brentru should be good now. Retested too.
image

brentru
brentru reviewed Aug 7, 2023
View reviewed changes
src/components/i2c/WipperSnapper_I2C.h Outdated
@@ -100,6 +101,7 @@ class WipperSnapper_Component_I2C {
WipperSnapper_I2C_Driver_BH1750 *_bh1750 = nullptr;
WipperSnapper_I2C_Driver_BME280 *_bme280 = nullptr;
WipperSnapper_I2C_Driver_BMP280 *_bmp280 = nullptr;
WipperSnapper_I2C_Driver_BMP3XX *_bmp388 = nullptr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too and don;'t forget to change _i2c.cpp as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) Read my slightly slow mind, just committing and retesting now

@tyeth
Copy link
Contributor Author

tyeth commented Aug 7, 2023

@brentru retested and resolved.
Just a thought, seems to not send a value initially until the polling period is expired (leaving at 15min default). Setting to 30seconds seems to trigger a send but not quite sure as not looked at that bit of code in context. Would be nice if it always sent the first values irrespective of the poll periods.
image

@brentru
Copy link
Member

brentru commented Aug 7, 2023

Would be nice if it always sent the first values irrespective of the poll periods.

Agreed, want to open an issue for this functionality?

@tyeth
Copy link
Contributor Author

tyeth commented Aug 7, 2023

Would be nice if it always sent the first values irrespective of the poll periods.

Agreed, want to open an issue for this functionality?

#463

@tyeth tyeth removed the request for review from lorennorman August 7, 2023 17:24
@brentru brentru merged commit b2ebe93 into adafruit:main Aug 7, 2023
24 checks passed
@tyeth tyeth deleted the add-bmp388 branch August 24, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyeth @brentru