Fix kill-ring-save for swiper-isearch #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default M-w binding of ivy-kill-ring-save expects ivy--old-cands to be a list of strings, but swiper-isearch has long switched to a list of buffer positions instead. * ivy.el (ivy-kill-ring-save): Prefer use-region-p over region-active-p. Use string-join. Tweak docstring. * swiper.el: Set swiper and swiper-isearch actions closer to their corresponding commands. (swiper--isearch-kill-ring-save): New command modeled after ivy-kill-ring-save. (swiper-isearch-map): Remap ivy-kill-ring-save and kill-ring-save to it. By default, the former remap is defensive, and only the latter is needed. Fixes #3000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
M-wbinding ofivy-kill-ring-saveexpectsivy--old-candsto be a list of strings, butswiper-isearchhas long switched to a list of buffer positions instead.ivy.el(ivy-kill-ring-save): Preferuse-region-poverregion-active-p. Usestring-join. Tweak docstring.swiper.el: Setswiperandswiper-isearchactions closer to their corresponding commands.(
swiper--isearch-kill-ring-save): New command modeled afterivy-kill-ring-save.(
swiper-isearch-map): Remapivy-kill-ring-saveandkill-ring-saveto it. By default, the former remap is defensive, and only the latter is needed.Fixes #3000.
Cc: @bgoodr