M-w (‘ivy-kill-ring-save’) errors out with: kill-new: Wrong type argument: sequencep, 20944

[bgoodr]

Version of ivy I'm using is : .emacs.d/elpa/ivy-20220926.1250/ivy.el

Steps to reproduce:

Open any buffer with text in it.

Type C-s to start a search (C-s is bound to swiper-isearch).

Type M-w to call ivy-kill-ring-save.

See the error:

kill-new: Wrong type argument: sequencep, 20944

Current definition of ivy-kill-ring-save:

(defun ivy-kill-ring-save ()
  "Store the current candidates into the kill ring.
If the region is active, forward to `kill-ring-save' instead."
  (interactive)
  (if (region-active-p)
      (call-interactively 'kill-ring-save)
    (kill-new
     (mapconcat
      #'identity
      ivy--old-cands
      "\n"))))

ivy--old-cands are not strings but sequence numbers of some sort. So that is the main symptom of the bug but I cannot find out what the intent was of that code.

[basil-conto]

kill-new: Wrong type argument: sequencep, 20944

Thanks for the report, and sorry for keeping you waiting.

ivy--old-cands are not strings but sequence numbers of some sort. So that is the main symptom of the bug but I cannot find out what the intent was of that code.

This is part of the sad set of regressions like those mentioned in #2963 between swiper and swiper-isearch. Both commands used to operate on a list of strings, but swiper-isearch later switched to a list of buffer positions without updating all relevant commands accordingly.

I hope PR #3070 addresses the issue.