Addon: [1.7.64] - Improved LootGoal state - many small fixes and optimizations #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addon: Obtain GetNumLootItems Addon: While collecting spellbook only extract the highest rank SpellId. This can help speed up InitState for high level characters. Addon: Bits for LootFrame and ChatFrame edit box is visible Fix: Addon: Cataclysm: Ammo and Pet happiness always returned false - however should have been the opposite.
Fix: Core: ApproachTargetGoal: While the PullTargetGoal was in progress and for some reason entered ApproachTargetGoal, if the target was not yet entered combat, prematurely cleared target.
Core: RequirementFactory: Added 'MenuOpen' and 'ChatInputVisible'
… OnEnter. It just logs the state dont early return. Significantly refactored Loot in order to keep track better of the states. More verbose logging. From now on also considers SoftInteract and its shenanigans like a herb or mining node is in the way...
Core: ApproachTargetGoal: Better blacklist detection. CombatTracker better integration Core: PullTargetGoal: Less likely to become stuck during the pull. The thread blocked less likely. Better detection the pull state
Xian55
added
documentation
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
GetNumLootItemsSpellId. This can help speed up InitState for high level characters.LOOT_RESET/LOOT_CORPSEwere not properly awaited.LootFrameandChatFrameedit box is visibleCataclysm: Ammo and Pet happiness always returned false - however should have been the oppositeApproachTargetGoal: While thePullTargetGoalwas in progress and for some reason enteredApproachTargetGoal, if the target was not yet entered combat, prematurely cleared target.RequirementFactory: Added'MenuOpen'and'ChatInputVisible'GoapAgent: setsGoapKey.pulledLootGoal:SkinningGoal: If the loot window still openOnEnter. It just logs the state dont early return. Significantly refactored Loot in order to keep track better of the states. More verbose logging. From now on also considers SoftInteract and its shenanigans like a herb or mining node is in the way...CombatGoal: better support forKeyActioninterruptionApproachTargetGoal: Better blacklist detection.CombatTrackerbetter integrationPullTargetGoal: Less likely to become stuck during the pull. The thread blocked less likely. Better detection the pull state