Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engaging in pvp #669

Open
Dragoo-beep opened this issue Jan 29, 2025 · 13 comments
Open

Engaging in pvp #669

Dragoo-beep opened this issue Jan 29, 2025 · 13 comments
Labels
bug Something isn't working

Comments

@Dragoo-beep
Copy link

Description

Engaging in pvp due to backend communication that we discussed in previously.

[13:16:33:647 W] [Blacklist ] Core.BlacklistTarget (0,16660,REMOVED) is player or pet!
[13:16:33:647 I] [FollowRouteGoal ] Blacklisted target found, clearing target
[13:16:33:693 I] [GoapAgent ] New Plan= Blacklist Target
[13:16:33:787 I] [GoapAgent ] New Plan= Follow Blasted Lands_ Big
[13:16:33:787 I] [Navigation ] [LocalPathingApi] distance is close 15.93441. Keep RouteToWaypoint.
[13:16:34:082 I] [GoapAgent ] New Plan= Approach Target
[13:16:34:129 I] [FollowRouteGoal ] Found target!
[13:16:34:176 I] [GoapAgent ] New Plan= Pull Target

So following the logs we are successful in blacklisting, goap agent recieved blacklist target, but goap agent also sends us to attack the target. So im at a loss for whats happening in the logic. That Goap agent both blacklists target, and engages target right after.

Addon Version

1.7.63

World of Warcraft Client

World of Warcraft Classic

Reproduction Steps

.

Last Good Version

No response

Screenshots

No response

Logs

No response

@Dragoo-beep Dragoo-beep added the bug Something isn't working label Jan 29, 2025
@Dragoo-beep
Copy link
Author

headless_out20250127.log
headless_out20250128.log
headless_out20250129.log

adding some logs if u wanna read but it should be basically same as last time

@Dragoo-beep
Copy link
Author

If you got tips to where I could try to tinker in code that would be awesome aswell as im learning c# in school

@Xian55
Copy link
Owner

Xian55 commented Jan 29, 2025

Hi thanks for the logs, i appreciate them. Currently working on other things(loot related issues).

If you got tips to where I could try to tinker in code

Your best bet looking at the logs all the class names are mentioned there such as

As i working on other issues i find a probable issue which cause all kinds of like pressing a button, the cause and effect are not properly detected. Still investigating.

@Xian55
Copy link
Owner

Xian55 commented Jan 31, 2025

Gooday, cce83a0 should help against enemy faction player pets

@Dragoo-beep
Copy link
Author

Dragoo-beep commented Feb 1, 2025

Gooday, cce83a0 should help against enemy faction player pets

Ill try it but ive never seen it engage pets unless we attack hunter and he feigns and we are then in combat with pet.

And the problem is somewhere in the communication as we have never failed to register a player as a player, but we just dont care xD

@Xian55
Copy link
Owner

Xian55 commented Feb 1, 2025

I've tried to reduce the race condition(s) while following the route and searching for possible targets 3f5b0ad

[13:16:33:647 W] [Blacklist        ] Core.BlacklistTarget (0,16660,REMOVED) is player or pet!

[13:16:33:647 I] [FollowRouteGoal  ] Blacklisted target found, clearing target       // At this point the player target should have been cleared

[13:16:33:693 I] [GoapAgent        ] New Plan=  Blacklist Target
[13:16:33:787 I] [GoapAgent        ] New Plan=  Follow  Blasted  Lands_ Big
[13:16:33:787 I] [Navigation       ] [LocalPathingApi] distance is close 15.93441. Keep RouteToWaypoint.
[13:16:34:082 I] [GoapAgent        ] New Plan=  Approach Target                        // And yet the player still has target
[13:16:34:129 I] [FollowRouteGoal  ] Found target!                                    // this are the kinds of issues what question my abilities :(
[13:16:34:176 I] [GoapAgent        ] New Plan=  Pull Target

@Dragoo-beep
Copy link
Author

Dragoo-beep commented Feb 2, 2025

Its very weird indeed. I tested it now and we instantly wanted to kill another guy :P I also tested some random fixes but to no success.
Logs from newest patch with no tinkering from my end:

headless_out20250202.log

Edit: Was it stopwatch that increased flush speed? That was quick!

@Xian55
Copy link
Owner

Xian55 commented Feb 3, 2025

Just published a new set of changes, putting more emphasis on respecting the Blacklist rules #673

@Dragoo-beep
Copy link
Author

Dragoo-beep commented Feb 4, 2025

Ooo nice testing right away - It looks promising! We have not attacked the first 10 players atleast!

headless_out20250204.log

@Dragoo-beep
Copy link
Author

Dragoo-beep commented Feb 4, 2025

We still attacked but it seems to be a bug where if the player is also targetting us, we fail to clear target and proceed eventually to engaging. All other times it seemed to work!

Tested on the same person where he didnt target us and we do NOT engage. So its purely if they target us.

Note: This is out of combat, and at a distance, so its not in self defense.

EDIT: We dont actually engage with the players, we just approach them then we stop, then if they move we continue to approach them lol!

headless_out20250204.log

@Dragoo-beep
Copy link
Author

I changed it back to else if (bits.Combat()) in PullTargetGoal will see if that works. It seems we atleast cleared target if they targetted me.

@Xian55
Copy link
Owner

Xian55 commented Feb 4, 2025

Gooday, thanks for taking the time and giving feedback, i appreciate it!

@Dragoo-beep
Copy link
Author

Gooday, thanks for taking the time and giving feedback, i appreciate it!

no problem - had it off for abit, it seems we still approached with else if (bits.Combat()) so it didnt work after all. Not sure whats causing it then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants