Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon: [1.7.60] - Improved CastingHandler spell detection, channeling support and wands #617

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

Xian55
Copy link
Owner

@Xian55 Xian55 commented Aug 17, 2024

Yet another attempt to improve the casting handler.
Please read the commit messages for further info.

Core: CastResult: Add more verbose info either an instant or castbar action result which can be exposed to the user

Core: ReactCastError: Handle CAST_SENT event

Core: Castinghandler: Consider channeling state during Castbar cast. Improved CurrentAction detection. Consider player latency during more state. Take advantage of CastResult. Cast function is responsible for retry attempt of failed casts. Improve code maintainability...
@Xian55 Xian55 added bugfix This pull request fixes an issue. enhancement This pull request implements a new feature. labels Aug 17, 2024
@Xian55 Xian55 merged commit 9c8da07 into dev Aug 17, 2024
1 check passed
@Xian55 Xian55 deleted the feature/improve-castinghandler-v4 branch August 17, 2024 00:14
@Xian55 Xian55 mentioned this pull request Aug 17, 2024
@Xian55 Xian55 changed the title Addon: [1.7.60] - Improved CastingHandler spell detection and wands Addon: [1.7.60] - Improved CastingHandler spell detection, channeling support and wands Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This pull request fixes an issue. enhancement This pull request implements a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Irregular Wand Shooting Not stopping to use bandage will move during channeling
1 participant