Skip to content

fix bug with the the explorer not scrollable #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MoritzGruber wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug with the the explorer not scrollable #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/wrapper.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
.graphiql-explorer-root {
font-size: var(--body-font-size) !important;
font-family: var(--editor-font-family) !important;
overflow: auto !important;
height: calc(100vh - 60px);
Copy link
Copy Markdown
Collaborator

@imolorhe imolorhe Sep 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't height of 100% work?

Copy link
Copy Markdown
Author

@MoritzGruber MoritzGruber Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it would not - feel free to give it a try

If you would use 100% this is would be the same as 100vh in this case. So the Top tabs (the 60px) would be too much with 100% and you would end up having two scrollbars 😌

}
.graphiql-explorer-root svg path {
fill: var(--theme-font-color) !important;
Expand Down