fix bug with the the explorer not scrollable#20
Open
MoritzGruber wants to merge 1 commit intoXKojiMedia:masterfrom
Open
fix bug with the the explorer not scrollable#20MoritzGruber wants to merge 1 commit intoXKojiMedia:masterfrom
MoritzGruber wants to merge 1 commit intoXKojiMedia:masterfrom
Conversation
fix bug with the the explorer not scrollable if there are more queries than one screen size can fit Bug: https://ibb.co/fFQHsxM Fix: https://ibb.co/4P8C2wL
imolorhe
reviewed
Sep 18, 2021
| font-size: var(--body-font-size) !important; | ||
| font-family: var(--editor-font-family) !important; | ||
| overflow: auto !important; | ||
| height: calc(100vh - 60px); |
Collaborator
There was a problem hiding this comment.
Wouldn't height of 100% work?
Author
There was a problem hiding this comment.
No it would not - feel free to give it a try
If you would use 100% this is would be the same as 100vh in this case. So the Top tabs (the 60px) would be too much with 100% and you would end up having two scrollbars 😌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi XKojiMedia,
thanks for the amazing work on Altair!
This MR is a bug fix with the the explorer not being scrollable if there are more queries than one screen size can fit
Current Behaviour:
The explorer is not scrollable in the right container if there are more queries to show than one screen size can fit.
Expected Behaviour:
The explorer is scrollable in the right container if there are more queries to show than one screen size can fit.
Bug:
https://ibb.co/fFQHsxM
Fix:
https://ibb.co/4P8C2
wL